Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752009AbcLBFQD (ORCPT ); Fri, 2 Dec 2016 00:16:03 -0500 Received: from 001b2d01.pphosted.com ([148.163.156.1]:53794 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbcLBFQC (ORCPT ); Fri, 2 Dec 2016 00:16:02 -0500 Subject: Re: [PATCH] powerpc: cputime: fix a compile warning To: yjin , Balbir Singh References: <1479704219-21403-1-git-send-email-yanjiang.jin@windriver.com> <874m2n7yrf.fsf@concordia.ellerman.id.au> <5840FA25.3010009@windriver.com> Cc: Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , oss@buserror.net, jinyanjiang@gmail.com, "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , "linux-kernel@vger.kernel.org" From: Pan Xinhui Date: Fri, 2 Dec 2016 13:15:39 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <5840FA25.3010009@windriver.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16120205-0016-0000-0000-0000039708FC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16120205-0017-0000-0000-000027CC8C07 Message-Id: <546ba7c8-999c-b393-b4b3-ee8602b724fd@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-02_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612020092 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2696 Lines: 73 在 2016/12/2 12:35, yjin 写道: > > On 2016年12月02日 12:22, Balbir Singh wrote: >> On Fri, Dec 2, 2016 at 3:15 PM, Michael Ellerman wrote: >>> yanjiang.jin@windriver.com writes: >>> >>>> diff --git a/arch/powerpc/include/asm/cputime.h b/arch/powerpc/include/asm/cputime.h >>>> index 4f60db0..4423e97 100644 >>>> --- a/arch/powerpc/include/asm/cputime.h >>>> +++ b/arch/powerpc/include/asm/cputime.h >>>> @@ -228,7 +228,8 @@ static inline cputime_t clock_t_to_cputime(const unsigned long clk) >>>> return (__force cputime_t) ct; >>>> } >>>> >>>> -#define cputime64_to_clock_t(ct) cputime_to_clock_t((cputime_t)(ct)) >>>> +#define cputime64_to_clock_t(ct) \ >>>> + (__force u64)(cputime_to_clock_t((cputime_t)(ct))) >>> Given the name of the function is "cputime64 to clock_t", surely we >>> should be returning a clock_t ? >> Please fix it in cpuacct.c Also check out git commit >> 527b0a76f41d062381adbb55c8eb61e32cb0bfc9 >> sched/cpuacct: Avoid %lld seq_printf warning > > Hi Balbir, > > Where can I find this commit? > hello, it is in next tree. :) commit 527b0a76f41d062381adbb55c8eb61e32cb0bfc9 Author: Martin Schwidefsky Date: Fri Nov 11 15:27:49 2016 +0100 sched/cpuacct: Avoid %lld seq_printf warning For s390 kernel builds I keep getting this warning: kernel/sched/cpuacct.c: In function 'cpuacct_stats_show': kernel/sched/cpuacct.c:298:25: warning: format '%lld' expects argument of type 'long long int', but argument 4 has type 'clock_t {aka long int}' [-Wformat=] seq_printf(sf, "%s %lld\n", Silence the warning by adding an explicit cast. Signed-off-by: Martin Schwidefsky Signed-off-by: Peter Zijlstra (Intel) Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Link: http://lkml.kernel.org/r/20161111142749.6545-1-schwidefsky@de.ibm.com Signed-off-by: Ingo Molnar diff --git a/kernel/sched/cpuacct.c b/kernel/sched/cpuacct.c index bc0b309c..9add206 100644 --- a/kernel/sched/cpuacct.c +++ b/kernel/sched/cpuacct.c @@ -297,7 +297,7 @@ static int cpuacct_stats_show(struct seq_file *sf, void *v) for (stat = 0; stat < CPUACCT_STAT_NSTATS; stat++) { seq_printf(sf, "%s %lld\n", cpuacct_stat_desc[stat], - cputime64_to_clock_t(val[stat])); + (long long)cputime64_to_clock_t(val[stat])); } return 0; > Thanks! > Yanjiang >> >> Balbir >