Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753461AbcLBGqL (ORCPT ); Fri, 2 Dec 2016 01:46:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:56968 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcLBGqJ (ORCPT ); Fri, 2 Dec 2016 01:46:09 -0500 Subject: Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version To: Duc Dang References: <1479201298-25494-1-git-send-email-tn@semihalf.com> <1479201298-25494-2-git-send-email-tn@semihalf.com> <20161201002812.GB9409@bhelgaas-glaptop.roam.corp.google.com> Cc: Bjorn Helgaas , Tomasz Nowicki , Jayachandran C , Gabriele Paoloni , Arnd Bergmann , Rafael Wysocki , Catalin Marinas , Ard Biesheuvel , Will Deacon , David Daney , Jeremy Linton , Linux Kernel Mailing List , Linaro ACPI Mailman List , linux-acpi@vger.kernel.org, Robert Richter , linux-pci@vger.kernel.org, Marcin Wojtas , Andrea Gallo , linux-arm , Christopher Covington From: Jon Masters Message-ID: <35d2f3b3-7337-f763-86be-2426d6041251@redhat.com> Date: Fri, 2 Dec 2016 01:45:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 02 Dec 2016 06:46:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 10043 Lines: 125 On 12/02/2016 01:42 AM, Duc Dang wrote: > On Thu, Dec 1, 2016 at 9:50 PM, Jon Masters wrote: >> On 11/30/2016 07:28 PM, Bjorn Helgaas wrote: >> >>> I'm hoping to end up with something like this: >>> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ecam&id=51ad4df79a9b7f2a66b346a46b21a785a2937469 >> >> The following build warnings happen using your branch on RHELSA7.3: >> >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> THUNDER_PEM_QUIRK(2, 0), /* off-chip devices */ >> ^ >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[44].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[44].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[45].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[45].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[46].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[46].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[47].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[47].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[48].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[48].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[49].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for ‘mcfg_quirks[49].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> THUNDER_PEM_QUIRK(2, 1), /* off-chip devices */ >> ^ >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[50].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[50].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[51].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[51].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[52].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[52].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[53].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[53].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[54].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[54].cfgres.end’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[55].cfgres.start’) [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default] >> drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for ‘mcfg_quirks[55].cfgres.end’) [enabled by default] > > I saw this too. It can be fixed by changes below: > > diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c > index 7319188..3d7c5cc 100644 > --- a/drivers/acpi/pci_mcfg.c > +++ b/drivers/acpi/pci_mcfg.c > @@ -98,16 +98,16 @@ struct mcfg_fixup { > { "CAVIUM", "THUNDERX", rev, seg, MCFG_BUS_ANY, \ > &pci_thunder_ecam_ops } > /* SoC pass1.x */ > - THUNDER_PEM_QUIRK(2, 0), /* off-chip devices */ > - THUNDER_PEM_QUIRK(2, 1), /* off-chip devices */ > - THUNDER_ECAM_QUIRK(2, 0), > - THUNDER_ECAM_QUIRK(2, 1), > - THUNDER_ECAM_QUIRK(2, 2), > - THUNDER_ECAM_QUIRK(2, 3), > - THUNDER_ECAM_QUIRK(2, 10), > - THUNDER_ECAM_QUIRK(2, 11), > - THUNDER_ECAM_QUIRK(2, 12), > - THUNDER_ECAM_QUIRK(2, 13), > + THUNDER_PEM_QUIRK(2, 0UL), /* off-chip devices */ > + THUNDER_PEM_QUIRK(2, 1UL), /* off-chip devices */ > + THUNDER_ECAM_QUIRK(2, 0UL), > + THUNDER_ECAM_QUIRK(2, 1UL), > + THUNDER_ECAM_QUIRK(2, 2UL), > + THUNDER_ECAM_QUIRK(2, 3UL), > + THUNDER_ECAM_QUIRK(2, 10UL), > + THUNDER_ECAM_QUIRK(2, 11UL), > + THUNDER_ECAM_QUIRK(2, 12UL), > + THUNDER_ECAM_QUIRK(2, 13UL), > > #define XGENE_V1_ECAM_MCFG(rev, seg) \ > {"APM ", "XGENE ", rev, seg, MCFG_BUS_ANY, \ ...which reminds me to followup on that project to get an Intel-style 0-day test service running for arm64. It's been kicking around too long. -- Computer Architect | Sent from my Fedora powered laptop