Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758310AbcLBIaF convert rfc822-to-8bit (ORCPT ); Fri, 2 Dec 2016 03:30:05 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:22703 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757939AbcLBI3r (ORCPT ); Fri, 2 Dec 2016 03:29:47 -0500 From: Fabien DESSENNE To: Shailendra Verma , Mauro Carvalho Chehab , "linux-media@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Shailendra Verma CC: "vidushi.koul@samsung.com" Date: Fri, 2 Dec 2016 09:29:30 +0100 Subject: Re: [PATCH] bdisp: Clean up file handle in open() error path. Thread-Topic: [PATCH] bdisp: Clean up file handle in open() error path. Thread-Index: AdJMdjPtiVySxVVxR4KR5KbI2WTbdQ== Message-ID: References: <1480654081-6983-1-git-send-email-shailendra.v@samsung.com> In-Reply-To: <1480654081-6983-1-git-send-email-shailendra.v@samsung.com> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 acceptlanguage: fr-FR, en-US Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-02_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 30 Hi Shailendra, Thank you for the patch, it's good for me. On 12/02/2016 05:48 AM, Shailendra Verma wrote: > The File handle is not yet added in the vdev list.So no need to call > v4l2_fh_del(&ctx->fh)if it fails to create control. > > Signed-off-by: Shailendra Verma Reviewed-by: Fabien Dessenne > --- > drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > index 45f82b5..fbf302f 100644 > --- a/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > +++ b/drivers/media/platform/sti/bdisp/bdisp-v4l2.c > @@ -632,8 +632,8 @@ static int bdisp_open(struct file *file) > > error_ctrls: > bdisp_ctrls_delete(ctx); > -error_fh: > v4l2_fh_del(&ctx->fh); > +error_fh: > v4l2_fh_exit(&ctx->fh); > bdisp_hw_free_nodes(ctx); > mem_ctx: