Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758418AbcLBIoy (ORCPT ); Fri, 2 Dec 2016 03:44:54 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:47606 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753396AbcLBIox (ORCPT ); Fri, 2 Dec 2016 03:44:53 -0500 Subject: Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming To: Corentin Labbe , References: <1480605581-13350-1-git-send-email-clabbe.montjoie@gmail.com> CC: , From: Giuseppe CAVALLARO Message-ID: <83a25cf8-907b-074e-754c-faa9e641c896@st.com> Date: Fri, 2 Dec 2016 09:44:48 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1480605581-13350-1-git-send-email-clabbe.montjoie@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.54] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-02_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 41 Hello Corentin patches look ok, I just wonder if you tested it in case of the stmmac is connected to a transceiver. Let me consider it a critical part of the driver to properly work. Regards Peppe On 12/1/2016 4:19 PM, Corentin Labbe wrote: > This patch simply rename regValue to value, like it was named in other > mdio functions. > > Signed-off-by: Corentin Labbe > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > index e3216e5..6796c28 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > @@ -83,14 +83,14 @@ static int stmmac_mdio_read(struct mii_bus *bus, int phyaddr, int phyreg) > unsigned int mii_data = priv->hw->mii.data; > > int data; > - u16 regValue = (((phyaddr << 11) & (0x0000F800)) | > + u16 value = (((phyaddr << 11) & (0x0000F800)) | > ((phyreg << 6) & (0x000007C0))); > - regValue |= MII_BUSY | ((priv->clk_csr & 0xF) << 2); > + value |= MII_BUSY | ((priv->clk_csr & 0xF) << 2); > > if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address)) > return -EBUSY; > > - writel(regValue, priv->ioaddr + mii_address); > + writel(value, priv->ioaddr + mii_address); > > if (stmmac_mdio_busy_wait(priv->ioaddr, mii_address)) > return -EBUSY; >