Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933254AbcLBIsl (ORCPT ); Fri, 2 Dec 2016 03:48:41 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:21040 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932795AbcLBIsZ (ORCPT ); Fri, 2 Dec 2016 03:48:25 -0500 Subject: Re: [PATCH 1/4] bindings: net: stmmac: correct note about TSO To: Niklas Cassel , Rob Herring , Mark Rutland , "David S. Miller" , Alexandre TORGUE , Phil Reid , Niklas Cassel , Eric Engestrom References: <1479911066-19752-1-git-send-email-niklass@axis.com> CC: , , From: Giuseppe CAVALLARO Message-ID: <1bae716e-2f18-ab4d-c88d-387d526c12bc@st.com> Date: Fri, 2 Dec 2016 09:48:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1479911066-19752-1-git-send-email-niklass@axis.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.54] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-02_04:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2301 Lines: 53 On 11/23/2016 3:24 PM, Niklas Cassel wrote: > From: Niklas Cassel > > snps,tso was previously placed under AXI BUS Mode parameters, > suggesting that the property should be in the stmmac-axi-config node. > > TSO (TCP Segmentation Offloading) has nothing to do with AXI BUS Mode > parameters, and the parser actually expects it to be in the root node, > not in the stmmac-axi-config. > > Also added a note about snps,tso only being available on GMAC4 and newer. > > Signed-off-by: Niklas Cassel Acked-by: Giuseppe Cavallaro > --- > Documentation/devicetree/bindings/net/stmmac.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt > index 41b49e6075f5..b95ff998ba73 100644 > --- a/Documentation/devicetree/bindings/net/stmmac.txt > +++ b/Documentation/devicetree/bindings/net/stmmac.txt > @@ -1,7 +1,7 @@ > * STMicroelectronics 10/100/1000 Ethernet driver (GMAC) > > Required properties: > -- compatible: Should be "snps,dwmac-" "snps,dwmac" > +- compatible: Should be "snps,dwmac-", "snps,dwmac" > For backwards compatibility: "st,spear600-gmac" is also supported. > - reg: Address and length of the register set for the device > - interrupt-parent: Should be the phandle for the interrupt controller > @@ -50,6 +50,8 @@ Optional properties: > - snps,ps-speed: port selection speed that can be passed to the core when > PCS is supported. For example, this is used in case of SGMII > and MAC2MAC connection. > +- snps,tso: this enables the TSO feature otherwise it will be managed by > + MAC HW capability register. Only for GMAC4 and newer. > - AXI BUS Mode parameters: below the list of all the parameters to program the > AXI register inside the DMA module: > - snps,lpi_en: enable Low Power Interface > @@ -62,8 +64,6 @@ Optional properties: > - snps,fb: fixed-burst > - snps,mb: mixed-burst > - snps,rb: rebuild INCRx Burst > - - snps,tso: this enables the TSO feature otherwise it will be managed by > - MAC HW capability register. > - mdio: with compatible = "snps,dwmac-mdio", create and register mdio bus. > > Examples: >