Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758669AbcLBI6w (ORCPT ); Fri, 2 Dec 2016 03:58:52 -0500 Received: from mail-wj0-f194.google.com ([209.85.210.194]:33135 "EHLO mail-wj0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753124AbcLBI6u (ORCPT ); Fri, 2 Dec 2016 03:58:50 -0500 Date: Fri, 2 Dec 2016 09:58:46 +0100 From: Corentin Labbe To: Giuseppe CAVALLARO Cc: alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming Message-ID: <20161202085846.GB20128@Red> References: <1480605581-13350-1-git-send-email-clabbe.montjoie@gmail.com> <83a25cf8-907b-074e-754c-faa9e641c896@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83a25cf8-907b-074e-754c-faa9e641c896@st.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 410 Lines: 15 On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote: > Hello Corentin > > patches look ok, I just wonder if you tested it in case of > the stmmac is connected to a transceiver. Let me consider it > a critical part of the driver to properly work. > > Regards > Peppe > I tested it on a Cubieboard 2 (dwmac-sunxi). What do you mean by "connected to a transceiver" ? an external PHY ? Regards