Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758858AbcLBJZh (ORCPT ); Fri, 2 Dec 2016 04:25:37 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:52507 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758234AbcLBJZf (ORCPT ); Fri, 2 Dec 2016 04:25:35 -0500 Subject: Re: [PATCH 1/2] net: stmmac: avoid Camelcase naming To: Corentin Labbe References: <1480605581-13350-1-git-send-email-clabbe.montjoie@gmail.com> <83a25cf8-907b-074e-754c-faa9e641c896@st.com> <20161202085846.GB20128@Red> CC: , , From: Giuseppe CAVALLARO Message-ID: Date: Fri, 2 Dec 2016 10:25:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20161202085846.GB20128@Red> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.54] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-02_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 25 On 12/2/2016 9:58 AM, Corentin Labbe wrote: > On Fri, Dec 02, 2016 at 09:44:48AM +0100, Giuseppe CAVALLARO wrote: >> Hello Corentin >> >> patches look ok, I just wonder if you tested it in case of >> the stmmac is connected to a transceiver. Let me consider it >> a critical part of the driver to properly work. >> >> Regards >> Peppe >> > > I tested it on a Cubieboard 2 (dwmac-sunxi). > What do you mean by "connected to a transceiver" ? an external PHY ? yes an external PHY. AFAIK, users have, sometime, a switch with fixed link enabled. Thx for your support and patches Acked-by: Giuseppe Cavallaro > > Regards >