Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759014AbcLBJem (ORCPT ); Fri, 2 Dec 2016 04:34:42 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:36744 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbcLBJei (ORCPT ); Fri, 2 Dec 2016 04:34:38 -0500 Date: Fri, 2 Dec 2016 10:28:40 +0100 From: Marcus Folkesson To: Richard Weinberger Cc: linux-mtd@lists.infradead.org, david@sigma-star.at, tytso@mit.edu, dedekind1@gmail.com, adrian.hunter@intel.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, adilger.kernel@dilger.ca, akpm@linux-foundation.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 4/6] ubifs: Maintain a parent pointer Message-ID: <20161202092840.i67lhgglzlnugwpd@gmail.com> References: <1480629741-18375-1-git-send-email-richard@nod.at> <1480629741-18375-5-git-send-email-richard@nod.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480629741-18375-5-git-send-email-richard@nod.at> User-Agent: NeoMutt/20161104 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 426 Lines: 15 On Thu, Dec 01, 2016 at 11:02:19PM +0100, Richard Weinberger wrote: > > + if (new_dir != old_dir) { > + fst_inode_ui->parent_inum = new_dir->i_ino; > + snd_inode_ui->parent_inum = old_dir->i_ino; > + } > + > if (old_dir != new_dir) { > if (S_ISDIR(fst_inode->i_mode) && !S_ISDIR(snd_inode->i_mode)) { > inc_nlink(new_dir); Insignificant thing, but use the existing if-statment instead? Cheers, Marcus Folkesson