Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932924AbcLBKHn (ORCPT ); Fri, 2 Dec 2016 05:07:43 -0500 Received: from mail-pg0-f49.google.com ([74.125.83.49]:34457 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753220AbcLBKHj (ORCPT ); Fri, 2 Dec 2016 05:07:39 -0500 Subject: Re: [PATCH v3 11/14] ACPI: irq: introduce interrupt producer To: Aleksey Makarov , Hanjun Guo , Marc Zyngier , "Rafael J. Wysocki" , Lorenzo Pieralisi References: <1477408169-22217-1-git-send-email-guohanjun@huawei.com> <1477408169-22217-12-git-send-email-guohanjun@huawei.com> <04573e29-6222-24f0-82f4-381367ee8bf0@gmail.com> Cc: linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thomas Gleixner , Greg KH , Tomasz Nowicki , Ma Jun , Kefeng Wang , Agustin Vega-Frias , Sinan Kaya , G Gregory , Charles Garcia-Tobin , huxinwei@huawei.com, yimin@huawei.com, linuxarm@huawei.com From: Hanjun Guo Message-ID: Date: Fri, 2 Dec 2016 18:07:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <04573e29-6222-24f0-82f4-381367ee8bf0@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1162 Lines: 41 Hi Aleksey, On 2016/12/1 19:12, Aleksey Makarov wrote: > > Hi Hanjun, > > On 10/25/2016 09:09 PM, Hanjun Guo wrote: >> From: Hanjun Guo >> >> In ACPI 6.1 spec, section 19.6.62, Interrupt Resource Descriptor Macro, > > [ ... ] > >> --- >> drivers/acpi/gsi.c | 10 ++++-- >> drivers/acpi/resource.c | 85 >> ++++++++++++++++++++++++++++++++++--------------- >> include/acpi/acpi_bus.h | 1 + >> 3 files changed, 68 insertions(+), 28 deletions(-) >> >> diff --git a/drivers/acpi/gsi.c b/drivers/acpi/gsi.c >> index ee9e0f2..29ee547 100644 >> --- a/drivers/acpi/gsi.c >> +++ b/drivers/acpi/gsi.c >> @@ -55,13 +55,19 @@ int acpi_register_gsi(struct device *dev, u32 gsi, >> int trigger, >> int polarity) >> { >> struct irq_fwspec fwspec; >> + struct acpi_device *adev = dev ? to_acpi_device(dev) : NULL; > > Why are you sure dev is always an acpi device? > Look for example at drivers/acpi/pci_irq.c:377 where this function > is called for a PCI device Good catch, but I will drop this patch and use Agustin's one [1]. [1]: https://mail-archive.com/linux-kernel@vger.kernel.org/msg1283116.html Thanks Hanjun