Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759360AbcLBKWp (ORCPT ); Fri, 2 Dec 2016 05:22:45 -0500 Received: from mga11.intel.com ([192.55.52.93]:21440 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750750AbcLBKWo (ORCPT ); Fri, 2 Dec 2016 05:22:44 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,729,1477983600"; d="scan'208";a="1067036981" Date: Fri, 2 Dec 2016 16:02:25 +0530 From: Vinod Koul To: Pan Bian Cc: Dan Williams , Dave Jiang , Julia Lawall , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] dma: ioat: set error code on failures Message-ID: <20161202103225.GM6408@localhost> References: <1480576212-26518-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480576212-26518-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 883 Lines: 25 On Thu, Dec 01, 2016 at 03:10:12PM +0800, Pan Bian wrote: > Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188591. In function > ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the > value of return variable err is 0 (indicates no error). As a result, the > return value may be inconsistent with the execution status. This patch > fixes the bug by assigning -ENOMEM to err on the error path. Please describe the fix you are doing. For Bugzilla you can use Fixes tag Also add the correct subsystem tag, so the changelog can look like: dmaengine: ioat: set error code on failures In ioat_dma_self_test(), when the calls to dma_mapping_error() fails, the value of return variable err is 0 ... Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188591 Fixes: Commit you fixes .. So please update the changelog and resend with Acks collected -- ~Vinod