Date: Fri, 2 Dec 2016 11:45:00 +0100
From: Robert Richter <robert.richter@cavium.com>
To: Tomasz Nowicki <tn@semihalf.com>
CC: Duc Dang <dhdang@apm.com>, Jon Masters <jcm@redhat.com>,
        Bjorn Helgaas <helgaas@kernel.org>,
        Jayachandran C <jchandra@broadcom.com>,
        Gabriele Paoloni <gabriele.paoloni@huawei.com>,
        Arnd Bergmann <arnd@arndb.de>, Rafael Wysocki <rafael@kernel.org>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Will Deacon <will.deacon@arm.com>,
        David Daney <ddaney@caviumnetworks.com>,
        Jeremy Linton <jeremy.linton@arm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linaro ACPI Mailman List <linaro-acpi@lists.linaro.org>,
        <linux-acpi@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        Marcin Wojtas <mw@semihalf.com>,
        Andrea Gallo <andrea.gallo@linaro.org>,
        linux-arm <linux-arm-kernel@lists.infradead.org>,
        Christopher Covington <cov@codeaurora.org>
Subject: Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI
 controller for ThunderX pass2.x silicon version
Message-ID: <20161202104500.GE10776@rric.localdomain>
References: <1479201298-25494-1-git-send-email-tn@semihalf.com>
 <1479201298-25494-2-git-send-email-tn@semihalf.com>
 <20161201002812.GB9409@bhelgaas-glaptop.roam.corp.google.com>
 <e5b1f09c-ca4c-fbf0-e9d7-c943ad0df2ff@redhat.com>
 <CADaLNDm8Zp_kAqVvSd0po9S3j2rSXxtUJ1M33dW7gLZzvueweQ@mail.gmail.com>
 <30ad6c65-4a4a-6346-00f6-11250133a251@semihalf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <30ad6c65-4a4a-6346-00f6-11250133a251@semihalf.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Dec 2016 10:45:21.2594 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR07MB2347
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1358
Lines: 44

On 02.12.16 11:06:24, Tomasz Nowicki wrote:
> On 02.12.2016 07:42, Duc Dang wrote:

> >@@ -98,16 +98,16 @@ struct mcfg_fixup {
> >        { "CAVIUM", "THUNDERX", rev, seg, MCFG_BUS_ANY,                 \
> >        &pci_thunder_ecam_ops }
> >        /* SoC pass1.x */
> >-   THUNDER_PEM_QUIRK(2,  0),       /* off-chip devices */
> >-   THUNDER_PEM_QUIRK(2,  1),       /* off-chip devices */
> >-   THUNDER_ECAM_QUIRK(2,  0),
> >-   THUNDER_ECAM_QUIRK(2,  1),
> >-   THUNDER_ECAM_QUIRK(2,  2),
> >-   THUNDER_ECAM_QUIRK(2,  3),
> >-   THUNDER_ECAM_QUIRK(2, 10),
> >-   THUNDER_ECAM_QUIRK(2, 11),
> >-   THUNDER_ECAM_QUIRK(2, 12),
> >-   THUNDER_ECAM_QUIRK(2, 13),
> >+ THUNDER_PEM_QUIRK(2, 0UL),  /* off-chip devices */
> >+ THUNDER_PEM_QUIRK(2, 1UL),  /* off-chip devices */
> >+ THUNDER_ECAM_QUIRK(2, 0UL),
> >+ THUNDER_ECAM_QUIRK(2, 1UL),
> >+ THUNDER_ECAM_QUIRK(2, 2UL),
> >+ THUNDER_ECAM_QUIRK(2, 3UL),
> >+ THUNDER_ECAM_QUIRK(2, 10UL),
> >+ THUNDER_ECAM_QUIRK(2, 11UL),
> >+ THUNDER_ECAM_QUIRK(2, 12UL),
> >+ THUNDER_ECAM_QUIRK(2, 13UL),
> >
> 
> The UL suffix is needed for *THUNDER_PEM_QUIRK* only. THUNDER_ECAM_QUIRK is
> fine.

We should better make the type cast part of the macro.

+ this:

---
#define THUNDER_MCFG_RES(addr, node) \
       DEFINE_RES_MEM(addr + (node << 44), 0x39 * SZ_16M)
---

The args in the macro need parentheses.

-Robert