Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760048AbcLBKtj (ORCPT ); Fri, 2 Dec 2016 05:49:39 -0500 Received: from mx2.mailbox.org ([80.241.60.215]:58267 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759368AbcLBKti (ORCPT ); Fri, 2 Dec 2016 05:49:38 -0500 Subject: Re: [PATCH v2] staging: wlan-ng: Fixed too long code line warnings. To: Yan Laijun , Greg Kroah-Hartman , Sergio Paracuellos , Bhumika Goyal References: <6d37d427c3203961e7f3f0020d2b971d92e7b52c.1480671565.git.yan.laijun@gmail.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Markus_B=c3=b6hme?= Message-ID: <4dd665e9-947c-1f32-59f8-77ba235aa5f8@mailbox.org> Date: Fri, 2 Dec 2016 11:49:24 +0100 MIME-Version: 1.0 In-Reply-To: <6d37d427c3203961e7f3f0020d2b971d92e7b52c.1480671565.git.yan.laijun@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1325 Lines: 40 On 12/02/2016 11:09 AM, Yan Laijun wrote: > Fixed checkpatch warning "line over 80 characters" in > wlan-ng/hfa384x_usb.c file. > > Signed-off-by: Yan Laijun > --- > Changes in v2: > - Remove initialization of usbin on its decarlation. > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index 5f11f6e..c7bda04 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -3037,7 +3037,7 @@ static void hfa384x_usbin_callback(struct urb *urb) > { > struct wlandevice *wlandev = urb->context; > struct hfa384x *hw; > - union hfa384x_usbin *usbin = (union hfa384x_usbin *)urb->transfer_buffer; > + union hfa384x_usbin *usbin; > struct sk_buff *skb = NULL; > int result; > int urb_status; > @@ -3049,6 +3049,7 @@ static void hfa384x_usbin_callback(struct urb *urb) > ABORT > } action; > > + usbin = (union hfa384x_usbin *)urb->transfer_buffer; > if (!wlandev || !wlandev->netdev || wlandev->hwremoved) > goto exit; > > If you separate declaration and assignment of usbin, maybe it makes sense to move the assignment down to where usbin is used for the first time. Regards, Markus