Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932691AbcLBL07 (ORCPT ); Fri, 2 Dec 2016 06:26:59 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42129 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760392AbcLBL06 (ORCPT ); Fri, 2 Dec 2016 06:26:58 -0500 Subject: Re: [PATCH v2 2/5] ia64: reuse append_elf_note() and final_note() functions To: Dave Young References: <148007477669.1053.4107773905913128028.stgit@hbathini.in.ibm.com> <148007484315.1053.12317233313990302812.stgit@hbathini.in.ibm.com> <20161201045653.GA13670@dhcp-128-65.nay.redhat.com> Cc: linux-kernel@vger.kernel.org, fenghua.yu@intel.com, tony.luck@intel.com, linux-ia64@vger.kernel.org, kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, ebiederm@xmission.com, Michael Ellerman , vgoyal@redhat.com From: Hari Bathini Date: Fri, 2 Dec 2016 16:56:48 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161201045653.GA13670@dhcp-128-65.nay.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16120211-7323-0000-0000-00000079D4E2 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16120211-7324-0000-0000-0000016C9EB0 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-02_08:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1612020187 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1983 Lines: 67 Hi Dave, Thanks for the review. On Thursday 01 December 2016 10:26 AM, Dave Young wrote: > Hi Hari > > Personally I like V1 more, but split the patch 2 is easier for ia64 > people to reivew. I did basic x86 testing, it runs ok. > > On 11/25/16 at 05:24pm, Hari Bathini wrote: >> Get rid of multiple definitions of append_elf_note() & final_note() >> functions. Reuse these functions compiled under CONFIG_CRASH_CORE. >> >> Signed-off-by: Hari Bathini >> --- >> arch/ia64/kernel/crash.c | 22 ---------------------- >> include/linux/crash_core.h | 4 ++++ >> kernel/crash_core.c | 6 +++--- >> kernel/kexec_core.c | 28 ---------------------------- >> 4 files changed, 7 insertions(+), 53 deletions(-) >> >> diff --git a/arch/ia64/kernel/crash.c b/arch/ia64/kernel/crash.c >> index 2955f35..75859a0 100644 >> --- a/arch/ia64/kernel/crash.c >> +++ b/arch/ia64/kernel/crash.c >> @@ -27,28 +27,6 @@ static int kdump_freeze_monarch; >> static int kdump_on_init = 1; >> static int kdump_on_fatal_mca = 1; >> >> -static inline Elf64_Word >> -*append_elf_note(Elf64_Word *buf, char *name, unsigned type, void *data, >> - size_t data_len) >> -{ >> - struct elf_note *note = (struct elf_note *)buf; >> - note->n_namesz = strlen(name) + 1; >> - note->n_descsz = data_len; >> - note->n_type = type; >> - buf += (sizeof(*note) + 3)/4; >> - memcpy(buf, name, note->n_namesz); >> - buf += (note->n_namesz + 3)/4; >> - memcpy(buf, data, data_len); >> - buf += (data_len + 3)/4; >> - return buf; >> -} >> - >> -static void >> -final_note(void *buf) >> -{ >> - memset(buf, 0, sizeof(struct elf_note)); >> -} >> - > The above IA64 version looks better than the functions in kexec_core.c > about the Elf64_Word type usage and the simpler final_note function. Hmmm.. Is void* better over Elf64_Word* to be agnostic of Elf32 or Elf64 type? > Care to update crash_core.c to use this instead? Sure. Will resend. Thanks Hari