Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758507AbcLBLvh (ORCPT ); Fri, 2 Dec 2016 06:51:37 -0500 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37460 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758231AbcLBLve (ORCPT ); Fri, 2 Dec 2016 06:51:34 -0500 Subject: Re: [RFC PATCH] PCI: designware: add host_init() error handling To: Joao Pinto , Bjorn Helgaas , linux-pci@vger.kernel.org References: <1480593077-15402-1-git-send-email-srinivas.kandagatla@linaro.org> Cc: Kishon Vijay Abraham I , Jingoo Han , Kukjin Kim , Krzysztof Kozlowski , Javier Martinez Canillas , Richard Zhu , Lucas Stach , Murali Karicheri , Minghuan Lian , Mingkai Hu , Roy Zang , Thomas Petazzoni , Jose Abreu , Pratyush Anand , Stanimir Varbanov , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arm-msm@vger.kernel.org From: Srinivas Kandagatla Message-ID: Date: Fri, 2 Dec 2016 11:51:26 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 37 On 02/12/16 10:32, Joao Pinto wrote: > > Hi Srinivas, > > ?s 11:51 AM de 12/1/2016, Srinivas Kandagatla escreveu: >> drivers/pci/host/pci-dra7xx.c | 4 +++- >> drivers/pci/host/pci-exynos.c | 4 +++- >> drivers/pci/host/pci-imx6.c | 4 +++- >> drivers/pci/host/pci-keystone.c | 4 +++- >> drivers/pci/host/pci-layerscape.c | 12 ++++++++---- >> drivers/pci/host/pcie-armada8k.c | 4 +++- >> drivers/pci/host/pcie-designware-plat.c | 4 +++- >> drivers/pci/host/pcie-designware.c | 4 +++- >> drivers/pci/host/pcie-designware.h | 2 +- >> drivers/pci/host/pcie-qcom.c | 6 ++++-- >> drivers/pci/host/pcie-spear13xx.c | 4 +++- >> 11 files changed, 37 insertions(+), 15 deletions(-) >> > > Thanks for the patch! > > In my opinion your idea is good but only qcom driver is able to detect failure > in the specific host init routine, all others have a 'return 0' even if > something not well init. I would recomend that we take this issue a bit further > and add the error checking to all specific pci drivers in order to make them as > robust as qcom'. I totally agree with you, I can give this a go in next version. Thanks, srini > > Thanks, > Joao >