Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S934063AbcLBOKd (ORCPT <rfc822;w@1wt.eu>);
        Fri, 2 Dec 2016 09:10:33 -0500
Received: from mga04.intel.com ([192.55.52.120]:1687 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1761919AbcLBOJH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Dec 2016 09:09:07 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,729,1477983600"; 
   d="scan'208";a="12670447"
Subject: Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS
 select
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
        linux-mmc@vger.kernel.org
References: <1480565146-4857-1-git-send-email-yamada.masahiro@socionext.com>
Cc: linux-kernel@vger.kernel.org, Stefan Wahren <stefan.wahren@i2se.com>,
        Al Cooper <alcooperx@gmail.com>,
        Wolfram Sang <wsa+renesas@sang-engineering.com>,
        Andrei Pistirica <andrei.pistirica@microchip.com>,
        Simon Horman <horms+renesas@verge.net.au>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Ulf Hansson <ulf.hansson@linaro.org>
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <0fe5583e-f1d3-242f-a510-e3ea3b3b5481@intel.com>
Date: Fri, 2 Dec 2016 16:03:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1480565146-4857-1-git-send-email-yamada.masahiro@socionext.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 881
Lines: 30

On 01/12/16 06:05, Masahiro Yamada wrote:
> I see no override of read/write callbacks in sdhci-of-at91.c.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
> 
> BTW, this config may not be so useful in recent multi-platforms.
> Perhaps, is it better to remove this config entirely instead of
> the AT91 fix only.
> 
> 
>  drivers/mmc/host/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 39f6f96..8ac1640 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -135,7 +135,6 @@ config MMC_SDHCI_OF_AT91
>  	tristate "SDHCI OF support for the Atmel SDMMC controller"
>  	depends on MMC_SDHCI_PLTFM
>  	depends on OF
> -	select MMC_SDHCI_IO_ACCESSORS
>  	help
>  	  This selects the Atmel SDMMC driver
>  
>