Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752957AbcLBRXQ (ORCPT ); Fri, 2 Dec 2016 12:23:16 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36968 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751488AbcLBRXN (ORCPT ); Fri, 2 Dec 2016 12:23:13 -0500 Date: Fri, 02 Dec 2016 12:23:11 -0500 (EST) Message-Id: <20161202.122311.1045081741040479698.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch Subject: Re: [PATCH net-next 3/6] net: dsa: mv88e6xxx: add a software reset op From: David Miller In-Reply-To: <20161130225930.25510-4-vivien.didelot@savoirfairelinux.com> References: <20161130225930.25510-1-vivien.didelot@savoirfairelinux.com> <20161130225930.25510-4-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 02 Dec 2016 08:23:50 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 429 Lines: 15 From: Vivien Didelot Date: Wed, 30 Nov 2016 17:59:27 -0500 > @@ -765,6 +765,9 @@ struct mv88e6xxx_ops { > int (*phy_write)(struct mv88e6xxx_chip *chip, int addr, int reg, > u16 val); > > + /* Switch Software Reset */ > + int (*reset)(struct mv88e6xxx_chip *chip); > + I think Andrew's request to name this method "g1_reset" is reasonable, please respin with that change. Thanks.