Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753413AbcLBRXd (ORCPT ); Fri, 2 Dec 2016 12:23:33 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:32936 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751845AbcLBRXK (ORCPT ); Fri, 2 Dec 2016 12:23:10 -0500 MIME-Version: 1.0 In-Reply-To: <14455987.OWjnZpEEup@wuerfel> References: <20161129131922.GA31466@angband.pl> <2899250.iZaPagXLk8@wuerfel> <14455987.OWjnZpEEup@wuerfel> From: Linus Torvalds Date: Fri, 2 Dec 2016 09:04:28 -0800 X-Google-Sender-Auth: SIHjzz0X1eKVokSmISg9s8wBIEE Message-ID: Subject: Re: [PATCH] x86/kbuild: enable modversions for symbols exported from asm To: Arnd Bergmann Cc: Adam Borowski , Greg Kroah-Hartman , Linux Kbuild mailing list , Michal Marek , Ben Hutchings , Debian kernel maintainers , "linux-arch@vger.kernel.org" , Ingo Molnar , Nicholas Piggin , Linux Kernel Mailing List , Alan Modra Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 26 On Fri, Dec 2, 2016 at 2:55 AM, Arnd Bergmann wrote: > > Yes, it's always been just the assembly symbols that broke, these were > the ones that Al's original patch changed and that ended up with > no version information. Ok, and the reason is because even if we have a weak symbol from C, it would always have a value. Good to know what the heck the problem was. > I have managed to bisect the link failure to a specific binutils > commit by Alan Modra now: Thanks. And I committed your "set to zero" patch, so we can hopefully leave this all behind us. I marked it for stable (not because older kernels need it, but because it's the right thing to do and if we ever backport anything that causes this we don't want to forget this). And I'll keep the workaround in kernel/module.c just because it's really late in the rc series, and I'd rather have both belt and suspenders for this all right now. Linus