Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753324AbcLBShE (ORCPT ); Fri, 2 Dec 2016 13:37:04 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38366 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbcLBShC (ORCPT ); Fri, 2 Dec 2016 13:37:02 -0500 Date: Fri, 02 Dec 2016 13:36:36 -0500 (EST) Message-Id: <20161202.133636.42467667676009914.davem@davemloft.net> To: asavkov@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jstancek@redhat.com, steffen.klassert@secunet.com, alexander.h.duyck@intel.com Subject: Re: [PATCH] ip6_offload: check segs for NULL in ipv6_gso_segment. From: David Miller In-Reply-To: <1480597564-32355-1-git-send-email-asavkov@redhat.com> References: <1480597564-32355-1-git-send-email-asavkov@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 02 Dec 2016 09:37:14 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 328 Lines: 9 From: Artem Savkov Date: Thu, 1 Dec 2016 14:06:04 +0100 > segs needs to be checked for being NULL in ipv6_gso_segment() before calling > skb_shinfo(segs), otherwise kernel can run into a NULL-pointer dereference: ... > Signed-off-by: Artem Savkov Applied and queued up for -stable.