Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756008AbcLBTBW (ORCPT ); Fri, 2 Dec 2016 14:01:22 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33030 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752096AbcLBTBU (ORCPT ); Fri, 2 Dec 2016 14:01:20 -0500 MIME-Version: 1.0 In-Reply-To: References: <1480132046-5406-1-git-send-email-a.mathur@samsung.com> From: Aniroop Mathur Date: Sat, 3 Dec 2016 00:31:18 +0530 Message-ID: Subject: Re: [PATCH] IIO: Change msleep to usleep_range for small msecs To: Linus Walleij Cc: Jonathan Cameron , Aniroop Mathur , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , "linux-iio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , s.samuel@samsung.com, r.mahale@samsung.com, Naveen Krishna Chatradhi , Linus Walleij , Vlad Dogaru Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 914 Lines: 25 On Wed, Nov 30, 2016 at 5:49 PM, Linus Walleij wrote: > On Sun, Nov 27, 2016 at 11:51 AM, Jonathan Cameron wrote: >> On 26/11/16 03:47, Aniroop Mathur wrote: > > [bmp280.c] > >>> /* Wait to make sure we started up properly */ >>> - mdelay(data->start_up_time); >>> + usleep_range(data->start_up_time, data->start_up_time + 100); >> >> As this in probe I doubt we really care. Could just set it longer to shut up the warnings. >> Still would like some input from say Linus on this... > > Hm, I don't think it's a big issue... this works too it just looks overworked. > > On the runtime_resume() path we use msleep() instead which I guess is why > it is not changed in this patch, but they have the same purpose. > I did change msleep to usleep_range in runtime_resume() in bmp280.c as you know resume time is critical indeed. > Yours, > Linus Walleij