Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754847AbcLBTUl (ORCPT ); Fri, 2 Dec 2016 14:20:41 -0500 Received: from mailrelay112.isp.belgacom.be ([195.238.20.139]:34953 "EHLO mailrelay112.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753436AbcLBTUj (ORCPT ); Fri, 2 Dec 2016 14:20:39 -0500 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AGAwDByEFY/9JLtVtcHgYMgzgBAQEBA?= =?us-ascii?q?R+BYKR3AZJGgg+CBoYighxAFAECAQEBAQEBAWIohRYvI09LJBOIc64DPYtfhj6?= =?us-ascii?q?PBQWaY5EUApA3kg0fN4EZgwoBgks9NIh+AQEB?= X-IPAS-Result: =?us-ascii?q?A2AGAwDByEFY/9JLtVtcHgYMgzgBAQEBAR+BYKR3AZJGgg+?= =?us-ascii?q?CBoYighxAFAECAQEBAQEBAWIohRYvI09LJBOIc64DPYtfhj6PBQWaY5EUApA3k?= =?us-ascii?q?g0fN4EZgwoBgks9NIh+AQEB?= From: Fabian Frederick To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, fabf@skynet.be Subject: [PATCH 3/8 linux-next] libnvdimm, namespace: move persistence warning Date: Fri, 2 Dec 2016 20:20:36 +0100 Message-Id: <1480706436-21058-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1230 Lines: 34 There's no need to warn on persistence yet as some validity tests are on the way. Signed-off-by: Fabian Frederick --- drivers/nvdimm/pmem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 822a712..204912c 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -266,9 +266,6 @@ static int pmem_attach_disk(struct device *dev, dev_set_drvdata(dev, pmem); pmem->phys_addr = res->start; pmem->size = resource_size(res); - if (nvdimm_has_flush(nd_region) < 0) - dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n"); - if (!devm_request_mem_region(dev, res->start, resource_size(res), dev_name(dev))) { dev_warn(dev, "could not reserve region %pR\n", res); @@ -279,6 +276,9 @@ static int pmem_attach_disk(struct device *dev, if (!q) return -ENOMEM; + if (nvdimm_has_flush(nd_region) < 0) + dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n"); + pmem->pfn_flags = PFN_DEV; if (is_nd_pfn(dev)) { addr = devm_memremap_pages(dev, &pfn_res, &q->q_usage_counter, -- 2.7.4