Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932088AbcLBTVE (ORCPT ); Fri, 2 Dec 2016 14:21:04 -0500 Received: from mailrelay112.isp.belgacom.be ([195.238.20.139]:11642 "EHLO mailrelay112.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479AbcLBTVB (ORCPT ); Fri, 2 Dec 2016 14:21:01 -0500 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AGAwDByEFY/9JLtVtcHgYMgzgBAQEBA?= =?us-ascii?q?R+BYKR3AZJGgg+CBoYighxAFAECAQEBAQEBAWIohRYvI09LJBOIc64DPYtfhj6?= =?us-ascii?q?PBQWaY5EUApA3kg0fN4EZgwoBgks9NIh+AQEB?= X-IPAS-Result: =?us-ascii?q?A2AGAwDByEFY/9JLtVtcHgYMgzgBAQEBAR+BYKR3AZJGgg+?= =?us-ascii?q?CBoYighxAFAECAQEBAQEBAWIohRYvI09LJBOIc64DPYtfhj6PBQWaY5EUApA3k?= =?us-ascii?q?g0fN4EZgwoBgks9NIh+AQEB?= From: Fabian Frederick To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, fabf@skynet.be Subject: [PATCH 4/8 linux-next] libnvdimm, namespace: avoid multiple sector calculations Date: Fri, 2 Dec 2016 20:20:56 +0100 Message-Id: <1480706456-21111-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1183 Lines: 36 add cleared_sectors variable to add more readability. Signed-off-by: Fabian Frederick --- drivers/nvdimm/pmem.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index 204912c..4da4735 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -52,16 +52,16 @@ static int pmem_clear_poison(struct pmem_device *pmem, phys_addr_t offset, { struct device *dev = to_dev(pmem); sector_t sector; - long cleared; + long cleared, cleared_sectors; sector = (offset - pmem->data_offset) / 512; cleared = nvdimm_clear_poison(dev, pmem->phys_addr + offset, len); - - if (cleared > 0 && cleared / 512) { + cleared_sectors = cleared / 512; + if (cleared > 0 && cleared_sectors) { dev_dbg(dev, "%s: %#llx clear %ld sector%s\n", - __func__, (unsigned long long) sector, - cleared / 512, cleared / 512 > 1 ? "s" : ""); - badblocks_clear(&pmem->bb, sector, cleared / 512); + __func__, (unsigned long long) sector, + cleared_sectors, cleared_sectors > 1 ? "s" : ""); + badblocks_clear(&pmem->bb, sector, cleared_sectors); } else { return -EIO; } -- 2.7.4