Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757150AbcLBTWN (ORCPT ); Fri, 2 Dec 2016 14:22:13 -0500 Received: from mailrelay112.isp.belgacom.be ([195.238.20.139]:65167 "EHLO mailrelay112.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbcLBTWL (ORCPT ); Fri, 2 Dec 2016 14:22:11 -0500 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2AAAwDByEFY/9JLtVtcHQEFAQsBgzgBA?= =?us-ascii?q?QEBAR+BYI1GlzEBkkaCD4IGhiKCHEAUAQIBAQEBAQEBYiiFRSNPSyQTiHOuQIt?= =?us-ascii?q?fhj6PBQWaY5EUApA3kg0fN4EZgwoBURyBXj00iH4BAQE?= X-IPAS-Result: =?us-ascii?q?A2AAAwDByEFY/9JLtVtcHQEFAQsBgzgBAQEBAR+BYI1GlzE?= =?us-ascii?q?BkkaCD4IGhiKCHEAUAQIBAQEBAQEBYiiFRSNPSyQTiHOuQItfhj6PBQWaY5EUA?= =?us-ascii?q?pA3kg0fN4EZgwoBURyBXj00iH4BAQE?= From: Fabian Frederick To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, fabf@skynet.be Subject: [PATCH 7/8 linux-next] mm: warn about possible alignment problem Date: Fri, 2 Dec 2016 20:22:07 +0100 Message-Id: <1480706527-21274-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 44 Commit 5f29a77cd957 ("mm: fix mixed zone detection in devm_memremap_pages") Aligned resource limits before region_intersects() which breaks the following with false assertions on kernel command line: memmap=4M!700M "devm_memremap_pages attempted on mixed region [ mem 0x2bc00000-0x2bfffff flags 0x200]" Memory regions 0x100000-0x2bbfffff: usable 0x2bc000000-0x2bbfffff: persistent 0x2c0000000-0x2bffffff: usable resource start: 0x2bc00000 align start: 0x28000000 resource size: 0x3fffffff align size: 0x80000000 SECTION_SIZE: 0x8000000 Now we need aligned memmap declarations based on 128M in this case eg memmap=128!640M Signed-off-by: Fabian Frederick --- kernel/memremap.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/memremap.c b/kernel/memremap.c index b501e39..1bb5eec 100644 --- a/kernel/memremap.c +++ b/kernel/memremap.c @@ -296,8 +296,8 @@ void *devm_memremap_pages(struct device *dev, struct resource *res, IORESOURCE_SYSTEM_RAM, IORES_DESC_NONE); if (is_ram == REGION_MIXED) { - WARN_ONCE(1, "%s attempted on mixed region %pr\n", - __func__, res); + WARN_ONCE(1, "%s attempted on mixed region %pr or arguments not aligned to section size: %#lx\n", + __func__, res, SECTION_SIZE); return ERR_PTR(-ENXIO); } -- 2.7.4