Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759544AbcLBTzn (ORCPT ); Fri, 2 Dec 2016 14:55:43 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:34954 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755935AbcLBTzl (ORCPT ); Fri, 2 Dec 2016 14:55:41 -0500 MIME-Version: 1.0 In-Reply-To: <1480706506-21222-1-git-send-email-fabf@skynet.be> References: <1480706506-21222-1-git-send-email-fabf@skynet.be> From: Dan Williams Date: Fri, 2 Dec 2016 11:55:40 -0800 Message-ID: Subject: Re: [PATCH 6/8 linux-next] libnvdimm, namespace: use octal for permissions To: Fabian Frederick Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 30 On Fri, Dec 2, 2016 at 11:21 AM, Fabian Frederick wrote: > According to commit f90774e1fd27 > ("checkpatch: look for symbolic permissions and suggest octal instead") > > Signed-off-by: Fabian Frederick > --- > drivers/nvdimm/namespace_devs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c > index b00045b..0d2da9a 100644 > --- a/drivers/nvdimm/namespace_devs.c > +++ b/drivers/nvdimm/namespace_devs.c > @@ -1132,7 +1132,7 @@ static ssize_t size_show(struct device *dev, > return sprintf(buf, "%llu\n", (unsigned long long) > nvdimm_namespace_capacity(to_ndns(dev))); > } > -static DEVICE_ATTR(size, S_IRUGO, size_show, size_store); > +static DEVICE_ATTR(size, 0444, size_show, size_store); > > static u8 *namespace_to_uuid(struct device *dev) > { > @@ -1456,7 +1456,7 @@ static umode_t namespace_visible(struct kobject *kobj, > > if (is_namespace_pmem(dev) || is_namespace_blk(dev)) { > if (a == &dev_attr_size.attr) > - return S_IWUSR | S_IRUGO; > + return 0200 | 0444; If we're going to use octal just go to "0644" directly.