Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755280AbcLBUNk (ORCPT ); Fri, 2 Dec 2016 15:13:40 -0500 Received: from mail-oi0-f52.google.com ([209.85.218.52]:35331 "EHLO mail-oi0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbcLBUNi (ORCPT ); Fri, 2 Dec 2016 15:13:38 -0500 MIME-Version: 1.0 In-Reply-To: <1480706456-21111-1-git-send-email-fabf@skynet.be> References: <1480706456-21111-1-git-send-email-fabf@skynet.be> From: Dan Williams Date: Fri, 2 Dec 2016 12:05:20 -0800 Message-ID: Subject: Re: [PATCH 4/8 linux-next] libnvdimm, namespace: avoid multiple sector calculations To: Fabian Frederick Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 25 On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick wrote: > add cleared_sectors variable to add more readability. > > Signed-off-by: Fabian Frederick > --- > drivers/nvdimm/pmem.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 204912c..4da4735 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -52,16 +52,16 @@ static int pmem_clear_poison(struct pmem_device *pmem, phys_addr_t offset, > { > struct device *dev = to_dev(pmem); > sector_t sector; > - long cleared; > + long cleared, cleared_sectors; > > sector = (offset - pmem->data_offset) / 512; > cleared = nvdimm_clear_poison(dev, pmem->phys_addr + offset, len); Let's skip adding a new 'cleared_sectors' variable and just adjust cleared to be in terms of sectors. Also, this patch collides with the latest contents of libnvdimm-pending, please respin.