Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753900AbcLBUxi (ORCPT ); Fri, 2 Dec 2016 15:53:38 -0500 Received: from mail-oi0-f41.google.com ([209.85.218.41]:33805 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbcLBUxg (ORCPT ); Fri, 2 Dec 2016 15:53:36 -0500 MIME-Version: 1.0 In-Reply-To: <1480706413-21004-1-git-send-email-fabf@skynet.be> References: <1480706413-21004-1-git-send-email-fabf@skynet.be> From: Dan Williams Date: Fri, 2 Dec 2016 12:53:34 -0800 Message-ID: Subject: Re: [PATCH 2/8 linux-next] libnvdimm, namespace: add verbosity to persistence warning To: Fabian Frederick Cc: "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 20 On Fri, Dec 2, 2016 at 11:20 AM, Fabian Frederick wrote: > Signed-off-by: Fabian Frederick > --- > drivers/nvdimm/pmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index 2461843..822a712 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -267,7 +267,7 @@ static int pmem_attach_disk(struct device *dev, > pmem->phys_addr = res->start; > pmem->size = resource_size(res); > if (nvdimm_has_flush(nd_region) < 0) > - dev_warn(dev, "unable to guarantee persistence of writes\n"); > + dev_warn(dev, "unable to guarantee persistence of writes due to unknown flushing capability of the memory region\n"); I'll pass on this one. Another reason could be that the flushing capability is present but disabled. Just seeing it's not guaranteed is sufficient.