From: KY Srinivasan <kys@microsoft.com>
To: Greg KH <gregkh@linuxfoundation.org>
CC: "olaf@aepfle.de" <olaf@aepfle.de>,
        "jasowang@redhat.com" <jasowang@redhat.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "apw@canonical.com" <apw@canonical.com>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "leann.ogasawara@canonical.com" <leann.ogasawara@canonical.com>
Subject: RE: [PATCH 02/15] hyperv: Add a function to detect hv_device
Thread-Topic: [PATCH 02/15] hyperv: Add a function to detect hv_device
Thread-Index: AQHSS+hcRHtOOpPMlEiibc7N0eIJt6DzjS2AgACaP1CAABDUgIAAAKewgAAMzQCAAIJ0gIAACyGAgABSA9A=
Date: Fri, 2 Dec 2016 21:41:50 +0000
Message-ID: <DM5PR03MB2490F1214BE79508650B722FA08E0@DM5PR03MB2490.namprd03.prod.outlook.com>
References: <1480613287-7748-1-git-send-email-kys@exchange.microsoft.com>
 <1480613332-7788-1-git-send-email-kys@exchange.microsoft.com>
 <1480613332-7788-2-git-send-email-kys@exchange.microsoft.com>
 <20161201203547.GB1602@kroah.com>
 <DM5PR03MB2490E2C37615C1B73C466455A08E0@DM5PR03MB2490.namprd03.prod.outlook.com>
 <20161202064805.GA19267@kroah.com>
 <DM5PR03MB2490E6811141C4713A689C6FA08E0@DM5PR03MB2490.namprd03.prod.outlook.com>
 <20161202073614.GA21628@kroah.com>
 <DM5PR03MB2490E658B9D8B479AD7AB402A08E0@DM5PR03MB2490.namprd03.prod.outlook.com>
 <20161202160259.GA6050@kroah.com>
In-Reply-To: <20161202160259.GA6050@kroah.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Dec 2016 21:41:50.7470
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1414
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id uB2Lg01U027256
Content-Length: 2966
Lines: 75


> -----Original Message-----
> From: Greg KH [mailto:gregkh@linuxfoundation.org]
> Sent: Friday, December 2, 2016 8:03 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: olaf@aepfle.de; jasowang@redhat.com; Haiyang Zhang
> <haiyangz@microsoft.com>; linux-kernel@vger.kernel.org;
> apw@canonical.com; devel@linuxdriverproject.org;
> leann.ogasawara@canonical.com
> Subject: Re: [PATCH 02/15] hyperv: Add a function to detect hv_device
> 
> On Fri, Dec 02, 2016 at 03:38:51PM +0000, KY Srinivasan wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > > Sent: Thursday, December 1, 2016 11:36 PM
> > > To: KY Srinivasan <kys@microsoft.com>
> > > Cc: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> > > olaf@aepfle.de; apw@canonical.com; vkuznets@redhat.com;
> > > jasowang@redhat.com; leann.ogasawara@canonical.com; Haiyang Zhang
> > > <haiyangz@microsoft.com>
> > > Subject: Re: [PATCH 02/15] hyperv: Add a function to detect hv_device
> > >
> > > On Fri, Dec 02, 2016 at 07:14:03AM +0000, KY Srinivasan wrote:
> > > > > In other words, why do you need this and PCI or USB doesn't?  Why is
> > > > > hyperv "special"?
> > > >
> > > > On Hyper-V, each VF interface (SR-IOV interface)
> > > > is paired with an instance of the
> > > > synthetic interface that is managed by netvsc.
> > > > When the VF interface comes up, we
> > > > need to associate the VF instance with
> > > > the corresponding netvsc instance. To do this
> > > > without modifying the VF drivers, netvsc registers
> > > > for netdev events.
> > >
> > > Why not modify the VF drivers?  You have the full source to them...
> > Greg,
> >
> > This is even worse. On Linux, VF drivers are hypervisor agnostic
> > and I want to keep it that way.
> 
> Ok, I really don't know what to suggest, other than this is probably not
> the way to do this as no other bus has to.  As I don't see the code that
> actually uses this anywhere, it's really impossible to have this
> conversation at all :(

I agree it is difficult to discuss this without
having the code that uses this.
That said, there is currently code in
the tree that disambiguates the netdev
events that netvsc sees - look at the function
get_netvsc_bymac(). This function allows us to 
associate the VF interface that maybe coming up with the
associated netvsc interface using MAC address. What I want to do
is to not use the MAC address but to use a serial number that the
host publishes. I could send the netvsc patches that use this if that
would help here. In any case once we have this functionality, we will be
submitting the patches that use this.

What I am trying to do here is to implement the equivalent of dev_is_pci()
for vmbus.
 
You also had concerns about how we were implementing this functionality.
We could certainly use the same mechanism used in dev_is_pci(). Perhaps
I could also use the same naming convention - dev_is_hv()?

Regards,

K. Y

> 
> greg k-h