Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754661AbcLCEgI (ORCPT ); Fri, 2 Dec 2016 23:36:08 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:40921 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751070AbcLCEgG (ORCPT ); Fri, 2 Dec 2016 23:36:06 -0500 Subject: Re: [PATCH] blk-stat: fix a typo To: Shaohua Li , References: <9d22314753c0874d41be54e0f8425a08974781b6.1480727312.git.shli@fb.com> CC: From: Jens Axboe Message-ID: Date: Fri, 2 Dec 2016 20:19:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: BLUPR13CA0073.namprd13.prod.outlook.com (10.160.82.44) To CY4PR15MB1191.namprd15.prod.outlook.com (10.172.177.13) X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;2:u7xJ40Bjrms5rakAlOiKyf6AT71vOBaaT5SEaZKPCfAPaXCTI/sRn+qvSVbgPUDfFNotioqbuSJlnaTvhB7Wdvko5pZL908BmigVCp7mJfLcf5x8GofFJqWhBtycwgbnojMeQy/qvSDrRzItjeyuGyZFvIZwbbhM+2jSgS/ufPU=;3:45PMj5PEvj++VHS9/IQm7xoSXWrb6PcYdnj0MwvKJNlo/eDobyrIcaSl5kEVuxh4znjcglDBmZmwFU50I0N03078vC7B3NSOc6n6K8E4DoYw1e7MPI1lTaJ72wgCmPMv8TqkZk9ZcajuXzVTD9f5yFBuvXjFtTGF5tVlcErqRxk=;25:EYWizjenZ/1XGgcCxYlY9J7OAgV4vQl5PeG+Uo9/FiZ+IQ1EFhe1tRDB/CUyqQhXxY4fHPMaqkywrX9RJhLguvqVWQXqL2Ug8lHWU8NpyCnA3h3g2BilebZUTaYZ0V0o9wJtq1I+d+EpJNriwjz8pJTACgZzbAQ9XbLDCwxIb8i//ttrSsRdl1n4jfqc8I+UrrIuPj9s/9Nz/uHhVajSDC7nMVtZ6La10v0p4L6LFcjgbSR7WzQV2hPZ2hgs8319bgisBCPkVcd64++V7IOiFz0w4fl5toJs0FqZAFa9Oz13uQs88R/9e3UA65EESeJn9ccmtrjreXdzfb5CdBuluUANQ4skff83bYz3bhbOQ66NUnEWXVXSli6UbDeEnGTosFeDe3Ze55hukHbKW5lPwGdf5UWaspHp1XkTQwbEyv6yVCslpB2XfFaRkUhk4T2nDoU4+uRYHim2iXc5ya30xQ== X-MS-Office365-Filtering-Correlation-Id: b9afc361-0f07-4f17-d6e1-08d41b2b3bda X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR15MB1191; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;31:QIXOfv+5S0kfgD8WS6r1rQn9/FTqUkLaojo1BvicRsotAwhwRnGyvFF6ohNuYMoKjLHQukRKZBVGZf3ZpOrZ7Qg8BuEzFJUBohuoMcPEMs5seP/ziOmysYEbx0CiT34EHB74PYg7Xu5Rru5CmxVM/EiddzUkftJm/g00gMBus7PKvi37S/SSSD+xqAHCpcUfym97RGD8BLok4ZyJcaUvr5+f6KgGQIKadfPiq2jDYYUf7nJL+0VcJVNlvaC/CLKDi1JKRzZxPTceXxjDRNYBEw==;20:/kdfrNsPFqtXULXvX2Q44ile+NP3jaUD8Vq0ULcc2LGlE/OkK7y2PLsJyZAgt3HfPqgQ5qsFxk+rc0FDI8Ir5Zk8kQgZaaeKPGLHYNYXcfGUcEs36sDHWhyST+OnaGxcbNHzBZH0PO/YL5t4FdGUbZT5e+zwb08Ddf8bLh3+lM+j8yY+RihWQen0rqoyfGScwUESvDjY22sOCcKbnkmHDKK4+HO+OOmG5jhpsYGhEvcwOhOJjkcCXvtyF0hb4RVr X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123562025)(20161123555025)(20161123564025)(6072148);SRVR:CY4PR15MB1191;BCL:0;PCL:0;RULEID:;SRVR:CY4PR15MB1191; X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;4:/GZvB2MJUQQFVv6bqdGiM/6uHTObBzM7vixuj92Cu2A5IsLvY+aina8VxwAWpcEFCGuUX+OCKxdZwQs5CnNwe6Rfg8i81ggA9FJK7i1UByz167lir6i+xQEhD/lhAvs0YdmLZnn7CWwF6Fy7mlUouhZtYtVamwd+597x+kQ/nyD083w8yTRZyLr9wEpCx+sHazOtgIxlXcBylodYwAbGldSSbDwMQD61laDkom1RXjmV8sPGGtssDIQWGqWouL3ZbhpI1SfOtcHS9JEyUOe0tNzYdCCueCrgokxaWZpRBD3PQrKUJU7GV+xN33cg9fEEU+/rJL3idTqM7hMhWY8ntxhoRysCj5jryNjWYGaCCSmuCU5SPChZRcRERcGWB4eBdDcFZLTtGEoVUjHVcGp1N2iC91fyo3QGLG5uB5IO/PYkIxs474pWAVn86gFrwYdQ1dtK6koHsFA1m2b6jTemkfUpEk/RyRoLVq1DDyItehv38dNbWSi5YSmJUb6auvuVK1fT3KOW69iLhEik9doH8CaA5aDuS4N9R3fdlj89K9794/BL8ZK0O+sV5zO6DJjZbuGmeTMoAygezAIrg3IFNqhEo7oIy6HABc1hcnF6zMdmunSDRtVum8aJFw1NbmVr X-Forefront-PRVS: 0145758B1D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(377454003)(189002)(199003)(24454002)(92566002)(50986999)(23746002)(6666003)(305945005)(105586002)(6486002)(8676002)(101416001)(54356999)(47776003)(76176999)(6116002)(229853002)(81156014)(31686004)(42186005)(7736002)(7846002)(39450400002)(230700001)(733004)(77096006)(39410400001)(83506001)(106356001)(2906002)(66066001)(2950100002)(97736004)(5001770100001)(36756003)(65826007)(450100001)(5660300001)(90366009)(81166006)(65806001)(3846002)(38730400001)(33646002)(31696002)(86362001)(4001350100001)(50466002)(64126003)(189998001)(117156001)(4326007)(68736007)(65956001);DIR:OUT;SFP:1102;SCL:1;SRVR:CY4PR15MB1191;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR15MB1191;23:7e1GEfDSfzTCRh8q/JTIGA3rgqQ9FH30/NV1N?= =?Windows-1252?Q?uUQHAVrXZ9dhdL+WHDkcNUbXakhXzKFIeuART5PjFj898YgzbO6NAbmR?= =?Windows-1252?Q?38/keRejhi9sdShRakFBH500o9gu7lWF9VdzhrYBaSVn37rKNWiAlz+s?= =?Windows-1252?Q?B8NMbNYz/NqD0/+KlL3tzA5A0XkxZJrC4kfXegz6s1ivQ+tmeE/uvsBJ?= =?Windows-1252?Q?D2gtMoAvAE5a3MKVOg/Mm+FnGp6CIGHE6qmxW502wuD21a45L3qP6+tC?= =?Windows-1252?Q?hZdWLQV97DVEsVN8FGw4Akd0+SJdAFLP0s//nuWtaybz19iFU0JUvmg6?= =?Windows-1252?Q?A02hv4fvt/4tfgR5IDtdUGiVr9ZcmYQAQHTH0cHrGLy/iEB/DdZCggS5?= =?Windows-1252?Q?rgtpBIAx7jsfN1sZx6xf1upU2oTDyHhHMnzz/y1Yir8kbqN5DQVmJY5k?= =?Windows-1252?Q?yB9lK4WBli01qfL8AtsiSjk7GPGIxqpt9XtL8GVeo6P6jz/QvMVPrwZJ?= =?Windows-1252?Q?vmzQWA5p7a+WW+5I0qPaq66JTh7J3B2FJFu2YL2eyGjiGv2liWrxxkYo?= =?Windows-1252?Q?zVSbdMd5Pe6jwovjSVORbNuypfuYwR9SyO+DEkr7Bb3BTjPprgmJKxnV?= =?Windows-1252?Q?KhcO7ntR3KSL36OJ5iUIk6sJaxKt+a6lcUjZKXBc9+jLOmeu56z+CUC4?= =?Windows-1252?Q?6Pd7sMSho7u1H/8QWtihl/IUvz/phQp4cp+Fj9T+V4mhBtWvUEeiyXPH?= =?Windows-1252?Q?VReE66dRJZqCQSpetFOK8p2tq2id5dBThCuGl0TKA3kr8KawhNOWiK+b?= =?Windows-1252?Q?68svhX8uh2En/Zwudi+u3LRbmuZu1pqy+tm5pb2vw+O0ZlvYeywRjCAz?= =?Windows-1252?Q?adl2FckB9OjFLmWhyVvGpA4si5nZ1nHfwfJaO41QGzEsK/4cH8ZCA/Tl?= =?Windows-1252?Q?cZ+k9sLdlAG40WVUKeuHQEk4NEejk+p+xPbVqm3e80pl1tYoghu63JWu?= =?Windows-1252?Q?iwSjnMqgKw5KQpZKr5ff2gSA7o4bMcm+MNOWAsbkAGqOZcRp86um79ls?= =?Windows-1252?Q?+ApHTnwNBFSiUh8cGf5wVKNtNu+sCog/p8dT2c/K9pw5E3iRxe4w1Wrr?= =?Windows-1252?Q?QSYdBpyHIoQWvchVKUd+mmQ6EsbHXb+y287ScmXqM6CIEy3HV38J+0vN?= =?Windows-1252?Q?+sqhMkd1nmiwgZHq+SYnawBilPtTes9vdMqzoGyQAOKMQ6/JNCaBQc62?= =?Windows-1252?Q?ej7nek1eLa3pZqDFrXF6+cEV2WpKpIgxLeG5cnDMGkG6ZSC/XelIlect?= =?Windows-1252?Q?TUU19MjI+Xgnfw48fOzOSNl+3MgzxI0Z9SkDDIloGpEZ4IWyiC9oBRf1?= =?Windows-1252?Q?m949/kr4OLkR3q/CMeSvZu2FVicF3sUmaBfE2hr/8Xvfd/GreIPmFldu?= =?Windows-1252?Q?STQ2CF5cLpyqDpnLPuA8tZok/4PhtXwnO5F88GZD4xGRWIBOHDZoo0ts?= =?Windows-1252?Q?duOywGo1MgLUlRTNYZAVoDFky1xMzbyf9tmyJ2+7BG0XccYZWbBPx+vW?= =?Windows-1252?Q?VrNqdgE7OxWsGSzptF1wvvhf9zjTVhDe6o7?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;6:NaP0lXOEhSzn0Pw1RkBGw+0+YB3euW71a+/5H7v7AdVjtqLMhrag/+TsTLBF1jWoHRbAuH7pn6YJ9eAtEghL75/Vg4NGufhmkXh04nmWC6/1KkVUtJiV9iSO7R7iYok6GdKl1nHSsHBDtmUCT/jTSiSK1JpJdMpN9f1wu1uOHyGfhx+ySPSANu3862RnjeVJQhThEP96z5iotRZPGve8EZ8VxQCh3OGi4ebmHggeVNo4RGLOdr/gFhvr3/8ZZ6rdVlO5GRTOGZH/2wNSzbuhgZevMqFAhNDSMISr+FE2gp2jyiW8aslt1uWsl9697V13KK8qU+5gVLQnddNVKnAqWHbqzhm6ZkWrjZ8duFQD0zU=;5:S8N5dY7KrAWLT9bmlM6FGqsjsl6i3BuyOGqDwWwGv6QsxiBcy+1ZoPWptauc5YCk2q4An+p/gxKtYYNU5wFQc3pHGCB0m44hyUJKA4ASgPOGA5lLFKsiPW1W5p8hZdmQsOqon4moQHR1msLPzmU/5g==;24:tkBhw1cZuCQNzHEp/sjdLknC7ITSPGPtiZl6HVYE9zAhL+7t6vqPa+BCeywVH+E1fYPFWw21j7HwsGbW6Rqpo0NOBnO/jEBsx2i0rkzMHNk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR15MB1191;7:jvhKn5PrDTr8xHK7WJRJY3RQh7fZjQgYyHzdw5g6RrkhNJjSdEcypO6cuffyP6yYSh70CHGn9s6OLqvaO0ZvCxP3FOV588JwUeEgetutSA3b6NLB+WYe37WS/UZKzkX+t3dLwc3ZZz6JX+LejEhK7w5C7DCj/K6J5mRyekUOxtmOxzKaEE3lh/ftBopU2QgiER+9fT215mrk/ccbQta06ktgdmjWPVv5+dXA5ENBS5q1TwkUxRRAQJ1ilMXbVc16lwuXsObLxK6WUNqxKZTXlvh0/bT37d0xmcWUMx9uaA9wrANyMfiuSN1J+HRttU8Ni3cZ5CDnYE73hE3lU8gBj2xxWu7eFCtyM6lrsQ2bW/U=;20:ZA2egQWie5U0dgRFIFWkjdKANCkoivLB7uh2Vdt5iRt+M8iOwUKR0zzU9NMpSbnM4bVMEqjEFi7fj1QJoxg+U20kN1cylQbdRFAO55Y1rE8n9CJ9dX9QqDdAQOCCUrXRvHm8MmsxGZpwAaC8EK7Fl50sHJT8O0a5lCsMYpCcMlU= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2016 03:19:45.8536 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1191 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-03_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 29 On 12/02/2016 08:16 PM, Jens Axboe wrote: > On 12/02/2016 06:13 PM, Shaohua Li wrote: >> Signed-off-by: Shaohua Li >> --- >> block/blk-stat.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/block/blk-stat.c b/block/blk-stat.c >> index 688c958..4d01185 100644 >> --- a/block/blk-stat.c >> +++ b/block/blk-stat.c >> @@ -12,7 +12,7 @@ >> static void blk_stat_flush_batch(struct blk_rq_stat *stat) >> { >> const s32 nr_batch = READ_ONCE(stat->nr_batch); >> - const s32 nr_samples = READ_ONCE(stat->nr_batch); >> + const s32 nr_samples = READ_ONCE(stat->nr_samples); >> >> if (!nr_batch) >> return; >> > > Gah, that sucks. Thanks, added for 4.10. BTW, this was added right before inclusion, all the previously posted versions were not broken in this way. So thanks for spotting this! -- Jens Axboe