Subject: Re: [PATCH] blk-stat: fix a typo
To: Shaohua Li <shli@fb.com>, <linux-kernel@vger.kernel.org>
References: <9d22314753c0874d41be54e0f8425a08974781b6.1480727312.git.shli@fb.com>
 <a579d4ff-59ad-760f-18f8-aceb88f71391@fb.com>
CC: <Kernel-team@fb.com>
From: Jens Axboe <axboe@fb.com>
Message-ID: <f00d75fa-d76e-50e1-2182-38de2731f2d1@fb.com>
Date: Fri, 2 Dec 2016 20:19:39 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <a579d4ff-59ad-760f-18f8-aceb88f71391@fb.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2016 03:19:45.8536 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR15MB1191
X-OriginatorOrg: fb.com
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-12-03_02:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 851
Lines: 29

On 12/02/2016 08:16 PM, Jens Axboe wrote:
> On 12/02/2016 06:13 PM, Shaohua Li wrote:
>> Signed-off-by: Shaohua Li <shli@fb.com>
>> ---
>>  block/blk-stat.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/blk-stat.c b/block/blk-stat.c
>> index 688c958..4d01185 100644
>> --- a/block/blk-stat.c
>> +++ b/block/blk-stat.c
>> @@ -12,7 +12,7 @@
>>  static void blk_stat_flush_batch(struct blk_rq_stat *stat)
>>  {
>>  	const s32 nr_batch = READ_ONCE(stat->nr_batch);
>> -	const s32 nr_samples = READ_ONCE(stat->nr_batch);
>> +	const s32 nr_samples = READ_ONCE(stat->nr_samples);
>>  
>>  	if (!nr_batch)
>>  		return;
>>
> 
> Gah, that sucks. Thanks, added for 4.10.

BTW, this was added right before inclusion, all the previously posted
versions were not broken in this way. So thanks for spotting this!

-- 
Jens Axboe