Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbcLCKLn (ORCPT ); Sat, 3 Dec 2016 05:11:43 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:34907 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbcLCKLj (ORCPT ); Sat, 3 Dec 2016 05:11:39 -0500 From: Chinmay VS X-Google-Original-From: Chinmay VS To: gregkh@linuxfoundation.org, elder@kernel.org, johan@kernel.org, pure.logic@nexus-software.ie Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, ChinmayVS Subject: [PATCH] staging: greybus: Fix macro definition Date: Sat, 3 Dec 2016 15:41:19 +0530 Message-Id: <1480759879-9646-1-git-send-email-cvs@nvidia.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 28 From: ChinmayVS Macros with multiple statements should be enclosed in a do - while loop Signed-off-by: ChinmayVS --- drivers/staging/greybus/loopback.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c index 7882306..39f0a25 100644 --- a/drivers/staging/greybus/loopback.c +++ b/drivers/staging/greybus/loopback.c @@ -177,9 +177,11 @@ static ssize_t name##_avg_show(struct device *dev, \ static DEVICE_ATTR_RO(name##_avg) #define gb_loopback_stats_attrs(field) \ +do { \ gb_loopback_ro_stats_attr(field, min, u); \ gb_loopback_ro_stats_attr(field, max, u); \ - gb_loopback_ro_avg_attr(field) + gb_loopback_ro_avg_attr(field) \ +} while (0) #define gb_loopback_attr(field, type) \ static ssize_t field##_show(struct device *dev, \ -- 2.7.4