Date: Sat, 3 Dec 2016 11:22:47 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Chinmay VS <cvs268@gmail.com>
Cc: elder@kernel.org, johan@kernel.org, pure.logic@nexus-software.ie,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: greybus: Fix macro definition
Message-ID: <20161203102247.GA15098@kroah.com>
References: <1480759879-9646-1-git-send-email-cvs@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1480759879-9646-1-git-send-email-cvs@nvidia.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1134
Lines: 31

On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote:
> From: ChinmayVS <cvs268@gmail.com>
> 
> Macros with multiple statements should be enclosed in a do - while loop
> 
> Signed-off-by: ChinmayVS <cvs268@gmail.com>
> ---
>  drivers/staging/greybus/loopback.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
> index 7882306..39f0a25 100644
> --- a/drivers/staging/greybus/loopback.c
> +++ b/drivers/staging/greybus/loopback.c
> @@ -177,9 +177,11 @@ static ssize_t name##_avg_show(struct device *dev,		\
>  static DEVICE_ATTR_RO(name##_avg)
>  
>  #define gb_loopback_stats_attrs(field)				\
> +do {								\
>  	gb_loopback_ro_stats_attr(field, min, u);		\
>  	gb_loopback_ro_stats_attr(field, max, u);		\
> -	gb_loopback_ro_avg_attr(field)
> +	gb_loopback_ro_avg_attr(field)				\
> +} while (0)
>  
>  #define gb_loopback_attr(field, type)					\
>  static ssize_t field##_show(struct device *dev,				\

Always build test your changes so you don't get a grumpy maintainer
yelling at you for not test-building your patches...