Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752127AbcLCKtJ (ORCPT ); Sat, 3 Dec 2016 05:49:09 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:33851 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbcLCKtF (ORCPT ); Sat, 3 Dec 2016 05:49:05 -0500 MIME-Version: 1.0 In-Reply-To: <20161203102247.GA15098@kroah.com> References: <1480759879-9646-1-git-send-email-cvs@nvidia.com> <20161203102247.GA15098@kroah.com> From: Chinmay V S Date: Sat, 3 Dec 2016 16:17:37 +0530 Message-ID: Subject: Re: [PATCH] staging: greybus: Fix macro definition To: Greg KH Cc: elder@kernel.org, johan@kernel.org, "Bryan O'Donoghue" , devel@driverdev.osuosl.org, linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 40 On Sat, Dec 3, 2016 at 3:52 PM, Greg KH wrote: > On Sat, Dec 03, 2016 at 03:41:19PM +0530, Chinmay VS wrote: >> From: ChinmayVS >> >> Macros with multiple statements should be enclosed in a do - while loop >> >> Signed-off-by: ChinmayVS >> --- >> drivers/staging/greybus/loopback.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c >> index 7882306..39f0a25 100644 >> --- a/drivers/staging/greybus/loopback.c >> +++ b/drivers/staging/greybus/loopback.c >> @@ -177,9 +177,11 @@ static ssize_t name##_avg_show(struct device *dev, \ >> static DEVICE_ATTR_RO(name##_avg) >> >> #define gb_loopback_stats_attrs(field) \ >> +do { \ >> gb_loopback_ro_stats_attr(field, min, u); \ >> gb_loopback_ro_stats_attr(field, max, u); \ >> - gb_loopback_ro_avg_attr(field) >> + gb_loopback_ro_avg_attr(field) \ >> +} while (0) >> >> #define gb_loopback_attr(field, type) \ >> static ssize_t field##_show(struct device *dev, \ > > Always build test your changes so you don't get a grumpy maintainer > yelling at you for not test-building your patches... > Thanks. My bad. Now that i tried and saw it doesn't even build, i see my mistake. gb_loopback_stats_attrs() is used to define functions from a template. The macro is not in any function by itself already. Back to running checkpatch and finding other ERRORs to cleanup in staging. (will remember to +V before pushing to the mailing list.)