Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263328AbTEMJMb (ORCPT ); Tue, 13 May 2003 05:12:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263373AbTEMJMb (ORCPT ); Tue, 13 May 2003 05:12:31 -0400 Received: from 237.oncolt.com ([213.86.99.237]:55774 "EHLO warthog.warthog") by vger.kernel.org with ESMTP id S263328AbTEMJMa (ORCPT ); Tue, 13 May 2003 05:12:30 -0400 To: "YOSHIFUJI Hideaki / ?$B5HF#1QL@?(B" , chris@wirex.com, davem@redhat.com, torvalds@transmeta.com, dhowells@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix net/rxrpc/proc.c In-Reply-To: <22117.1052817698@warthog.warthog> User-Agent: EMH/1.14.1 SEMI/1.14.4 (Hosorogi) FLIM/1.14.4 (=?ISO-8859-4?Q?Kashiharajing=FE-mae?=) APEL/10.4 Emacs/21.2 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.4 - "Hosorogi") Content-Type: text/plain; charset=US-ASCII Date: Tue, 13 May 2003 10:25:04 +0100 Message-ID: <22151.1052817904@warthog.warthog> From: David Howells Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 29 > > Thanks, sorry, I should have Cc:'d you in the first place, my apology. > > Seems like the rxrpc_proc_calls_fops should get an owner as well? > > (relative to the last patch) > > Should all file_operations tables associated with this be "owned" in this > manner? Hmmm... actually, looking at the code, it ought to be unnecessary as the proc entries are "owned", eg: int rxrpc_proc_init(void) { struct proc_dir_entry *p; proc_rxrpc = proc_mkdir("rxrpc",proc_net); if (!proc_rxrpc) goto error; proc_rxrpc->owner = THIS_MODULE; ... } David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/