Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752217AbcLCMsp (ORCPT ); Sat, 3 Dec 2016 07:48:45 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:36770 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbcLCMso (ORCPT ); Sat, 3 Dec 2016 07:48:44 -0500 MIME-Version: 1.0 Reply-To: cwchoi00@gmail.com In-Reply-To: <1480755409-3022-1-git-send-email-bianpan2016@163.com> References: <1480755409-3022-1-git-send-email-bianpan2016@163.com> From: Chanwoo Choi Date: Sat, 3 Dec 2016 21:48:23 +0900 Message-ID: Subject: Re: [PATCH 1/1] extcon: return error code on failure To: Pan Bian , Greg KH Cc: MyungJoo Ham , Chanwoo Choi , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1223 Lines: 40 Hi Pan, 2016-12-03 17:56 GMT+09:00 Pan Bian : > Function get_zeroed_page() returns a NULL pointer if there is no enough > memory. In function extcon_sync(), it returns 0 if the call to > get_zeroed_page() fails. The return value 0 indicates success in the > context, which is incosistent with the execution status. This patch > fixes the bug by returning -ENOMEM. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188611 > > Signed-off-by: Pan Bian > --- > drivers/extcon/extcon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 7829846..7c1e3a7 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -453,7 +453,7 @@ int extcon_sync(struct extcon_dev *edev, unsigned int id) > dev_err(&edev->dev, "out of memory in extcon_set_state\n"); > kobject_uevent(&edev->dev.kobj, KOBJ_CHANGE); > > - return 0; > + return -ENOMEM; > } > > length = name_show(&edev->dev, NULL, prop_buf); > -- > 1.9.1 > > Looks good to me. Acked-by: Chanwoo Choi Best Regards, Chanwoo Choi