Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751736AbcLCM4E (ORCPT ); Sat, 3 Dec 2016 07:56:04 -0500 Received: from m50-133.163.com ([123.125.50.133]:35664 "EHLO m50-133.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbcLCM4D (ORCPT ); Sat, 3 Dec 2016 07:56:03 -0500 From: Pan Bian To: Oleg Drokin , Andreas Dilger , James Simmons , Greg Kroah-Hartman , Dmitry Eremin , Frank Zago Cc: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH 1/1] staging: lustre: lnet: fix improper return value Date: Sat, 3 Dec 2016 20:52:55 +0800 Message-Id: <1480769575-6074-1-git-send-email-bianpan201602@163.com> X-Mailer: git-send-email 1.9.1 X-CM-TRANSID: DdGowADX6agnwEJYo1Y8Iw--.56298S3 X-Coremail-Antispam: 1Uf129KBjvdXoW7Jw47Zw43CFWxKFWkuFWrAFb_yoW3Wrg_G3 92qa4xKrZYyFWF9w1FqFW3ZryI9a13ZrsYyF15t39xA3W5Cr4avF4kZF1DW34fWa13Wr9F krn2yF1F9r17XjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUYNYFJUUUUU== X-Originating-IP: [222.131.246.88] X-CM-SenderInfo: held01tdqsiiqwqsqiywtou0bp/1tbiWAs14FUL-BBYfAAAsQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 719 Lines: 28 From: Pan Bian At the end of function lstcon_group_info(), "return 0" seems improper. It may be better to return the value of rc. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811 Signed-off-by: Pan Bian --- drivers/staging/lustre/lnet/selftest/console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c index a0fcbf3..9a7c41a 100644 --- a/drivers/staging/lustre/lnet/selftest/console.c +++ b/drivers/staging/lustre/lnet/selftest/console.c @@ -820,7 +820,7 @@ lstcon_group_decref(grp); - return 0; + return rc; } static int -- 1.9.1