Subject: Re: [PATCH 1/1] net: caif: fix ineffective error check
To: Pan Bian <bianpan2016@163.com>,
        Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
References: <1480763901-5323-1-git-send-email-bianpan2016@163.com>
Cc: linux-kernel@vger.kernel.org
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <f214a441-9e4b-6c40-f09d-32a6d1ea4dd0@cogentembedded.com>
Date: Sat, 3 Dec 2016 16:17:51 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1480763901-5323-1-git-send-email-bianpan2016@163.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 873
Lines: 34

Hello.

On 12/3/2016 2:18 PM, Pan Bian wrote:

> In function caif_sktinit_module(), the check of the return value of
> sock_register() seems ineffective. This patch fixes it.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188751
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
> ---
>  net/caif/caif_socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/caif/caif_socket.c b/net/caif/caif_socket.c
> index aa209b1..2a689a3 100644
> --- a/net/caif/caif_socket.c
> +++ b/net/caif/caif_socket.c
> @@ -1108,7 +1108,7 @@ static int caif_create(struct net *net, struct socket *sock, int protocol,
>  static int __init caif_sktinit_module(void)
>  {
>  	int err = sock_register(&caif_family_ops);
> -	if (!err)
> +	if (err)
>  		return err;

    Why not just:

	return sock_register(&caif_family_ops);

>  	return 0;
>  }

MBR, Sergei