Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752923AbcLCQQz (ORCPT ); Sat, 3 Dec 2016 11:16:55 -0500 Received: from mga02.intel.com ([134.134.136.20]:15179 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbcLCQQx (ORCPT ); Sat, 3 Dec 2016 11:16:53 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,736,1477983600"; d="scan'208";a="908365200" Date: Sat, 3 Dec 2016 18:15:57 +0200 From: Jarkko Sakkinen To: Tomas Winkler Cc: tpmdd-devel@lists.sourceforge.net, Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Subject: Re: [PATCH v2 1/4] tpm: add kdoc for tpm_transmit and tpm_transmit_cmd Message-ID: <20161203161557.ddqkt46sol55iode@intel.com> References: <1479895454-15076-1-git-send-email-tomas.winkler@intel.com> <1479895454-15076-2-git-send-email-tomas.winkler@intel.com> <20161203153236.jmulnrlvoitvjnhq@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161203153236.jmulnrlvoitvjnhq@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 20 On Sat, Dec 03, 2016 at 05:32:36PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 23, 2016 at 12:04:11PM +0200, Tomas Winkler wrote: > > Functions tpm_transmit and transmit_cmd are referenced > > from other functions kdoc hence deserve documentation. > > > > Signed-off-by: Tomas Winkler > > Do you mind if I change TPM_DIGEST_SIZE to SHA1_DIGEST_SIZE? > > I'm looking to drop TPM_DIGEST_SIZE eventually. > > Reviewed-by: Jarkko Sakkinen Tested-by: Jarkko Sakkinen ... in the sense that the changes do not break the compilation and do not produce sparse or cocciheck errors. I guess that should be enough for documentation changes. /Jarkko