Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752671AbcLCSyV (ORCPT ); Sat, 3 Dec 2016 13:54:21 -0500 Received: from mailrelay104.isp.belgacom.be ([195.238.20.131]:51106 "EHLO mailrelay104.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751433AbcLCSyT (ORCPT ); Sat, 3 Dec 2016 13:54:19 -0500 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2DSAgDlE0NY/9JLtVtdHQEFAQsBgzgBA?= =?us-ascii?q?QEBAR+BYI1HlzABkkeCD4IIhiKCHkAUAQIBAQEBAQEBYiiFRSNPSyQTiHOvZot?= =?us-ascii?q?jhj6PBAWaZpEXApA7PZFSHzeBGYMKAYJLPTSKAAEBAQ?= X-IPAS-Result: =?us-ascii?q?A2DSAgDlE0NY/9JLtVtdHQEFAQsBgzgBAQEBAR+BYI1HlzA?= =?us-ascii?q?BkkeCD4IIhiKCHkAUAQIBAQEBAQEBYiiFRSNPSyQTiHOvZotjhj6PBAWaZpEXA?= =?us-ascii?q?pA7PZFSHzeBGYMKAYJLPTSKAAEBAQ?= From: Fabian Frederick To: Dan Williams Cc: linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org, fabf@skynet.be Subject: [PATCH V2 3/3 libnvdimm-pending] libnvdimm, namespace: use octal for permissions Date: Sat, 3 Dec 2016 19:54:06 +0100 Message-Id: <1480791246-21449-1-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1194 Lines: 35 According to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead") Signed-off-by: Fabian Frederick --- V2: applied on top of libnvdimm-pending Use calculated value instead of a | b (Suggested by Dan Williams) drivers/nvdimm/namespace_devs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c index 7569ba7..6bf60f3 100644 --- a/drivers/nvdimm/namespace_devs.c +++ b/drivers/nvdimm/namespace_devs.c @@ -1132,7 +1132,7 @@ static ssize_t size_show(struct device *dev, return sprintf(buf, "%llu\n", (unsigned long long) nvdimm_namespace_capacity(to_ndns(dev))); } -static DEVICE_ATTR(size, S_IRUGO, size_show, size_store); +static DEVICE_ATTR(size, 0444, size_show, size_store); static u8 *namespace_to_uuid(struct device *dev) { @@ -1456,7 +1456,7 @@ static umode_t namespace_visible(struct kobject *kobj, if (is_namespace_pmem(dev) || is_namespace_blk(dev)) { if (a == &dev_attr_size.attr) - return S_IWUSR | S_IRUGO; + return 0644; if (is_namespace_pmem(dev) && a == &dev_attr_sector_size.attr) return 0; -- 2.7.4