Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751512AbcLCUZ0 (ORCPT <rfc822;w@1wt.eu>);
        Sat, 3 Dec 2016 15:25:26 -0500
Received: from shards.monkeyblade.net ([184.105.139.130]:36802 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751038AbcLCUZZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 3 Dec 2016 15:25:25 -0500
Date: Sat, 03 Dec 2016 15:25:15 -0500 (EST)
Message-Id: <20161203.152515.1155017126921048869.davem@davemloft.net>
To: salil.mehta@huawei.com
Cc: yisen.zhuang@huawei.com, mehta.salil.lnk@gmail.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com
Subject: Re: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX
 checksum flag to stack
From: David Miller <davem@davemloft.net>
In-Reply-To: <F4CC6FACFEB3C54C9141D49AD221F7F91A7D5EF1@lhreml503-mbx>
References: <20161129130945.919372-1-salil.mehta@huawei.com>
        <20161130.142539.1927956259851457047.davem@davemloft.net>
        <F4CC6FACFEB3C54C9141D49AD221F7F91A7D5EF1@lhreml503-mbx>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 03 Dec 2016 11:25:54 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 315
Lines: 10

From: Salil Mehta <salil.mehta@huawei.com>
Date: Thu, 1 Dec 2016 16:59:14 +0000

> It looks to me the cumbersome check in the PATCH V2 should
> be retained.

I really want something simpler with small checks that are
done in logical pieces in a straigtforward progression.

The code in V2 is completely unreadable.