Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbcLCUep (ORCPT ); Sat, 3 Dec 2016 15:34:45 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:36950 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751792AbcLCUem (ORCPT ); Sat, 3 Dec 2016 15:34:42 -0500 Date: Sat, 03 Dec 2016 15:24:18 -0500 (EST) Message-Id: <20161203.152418.772961535189895221.davem@davemloft.net> To: clabbe.montjoie@gmail.com Cc: peppe.cavallaro@st.com, alexandre.torgue@st.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: stmmac: unify mdio functions From: David Miller In-Reply-To: <1480605581-13350-2-git-send-email-clabbe.montjoie@gmail.com> References: <1480605581-13350-1-git-send-email-clabbe.montjoie@gmail.com> <1480605581-13350-2-git-send-email-clabbe.montjoie@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 03 Dec 2016 11:24:56 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 489 Lines: 14 From: Corentin Labbe Date: Thu, 1 Dec 2016 16:19:41 +0100 > stmmac_mdio_{read|write} and stmmac_mdio_{read|write}_gmac4 are not > enought different for being split. > The only differences between thoses two functions are shift/mask for > addr/reg/clk_csr. > > This patch introduce a per platform set of variable for setting thoses > shift/mask and unify mdio read and write functions. > > Signed-off-by: Corentin Labbe Applied.