Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752396AbcLDEB3 (ORCPT ); Sat, 3 Dec 2016 23:01:29 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:37800 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbcLDEBZ (ORCPT ); Sat, 3 Dec 2016 23:01:25 -0500 Date: Sun, 4 Dec 2016 04:00:33 +0000 From: Al Viro To: David Howells Cc: linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available [ver #3] Message-ID: <20161204040026.GA32055@ZenIV.linux.org.uk> References: <147986254484.19139.8038609825799670925.stgit@warthog.procyon.org.uk> <147986255194.19139.9583434946564699577.stgit@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <147986255194.19139.9583434946564699577.stgit@warthog.procyon.org.uk> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 805 Lines: 27 On Wed, Nov 23, 2016 at 12:55:51AM +0000, David Howells wrote: > -int vfs_getattr_nosec(struct path *path, struct kstat *stat) > +int vfs_xgetattr_nosec(struct path *path, struct kstat *stat) const struct path *, please. Especially since we feed &file->f_path to it. And yes, I realize that the same applies to vfs_getattr() in the current tree. > +int vfs_xgetattr(struct path *path, struct kstat *stat) Ditto. > +int vfs_getattr(struct path *path, struct kstat *stat) Again. > +#define __put_timestamp(kts, uts) ( \ > + __put_user(kts.tv_sec, uts.tv_sec ) || \ > + __put_user(kts.tv_nsec, uts.tv_nsec ) || \ > + __put_user(0, uts.__reserved )) static inline. > +#define KSTAT_ATTR_FS_IOC_FLAGS 0x00000874 /* Attrs corresponding to FS_*_FL flags */ Err... An explicit hex constant?