Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751347AbcLDKkz (ORCPT ); Sun, 4 Dec 2016 05:40:55 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:36893 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcLDKkw (ORCPT ); Sun, 4 Dec 2016 05:40:52 -0500 Subject: Re: [PATCH 1/1] isdn: hisax: set error code on failure To: Pan Bian , Karsten Keil , netdev@vger.kernel.org References: <1480847603-15520-1-git-send-email-bianpan201603@163.com> Cc: linux-kernel@vger.kernel.org, Pan Bian From: Sergei Shtylyov Message-ID: <7d61be6f-ef55-acd6-da54-a8171631826f@cogentembedded.com> Date: Sun, 4 Dec 2016 13:40:48 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1480847603-15520-1-git-send-email-bianpan201603@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 697 Lines: 27 On 12/4/2016 1:33 PM, Pan Bian wrote: You now need to indicate the patch version in hte subject, like this: [PATCH 1/1 v2] isdn:... > From: Pan Bian > > In function hfc4s8s_probe(), the value of return variable err should be > negative on failures. However, when the call to request_region() returns > NULL, the value of err is 0. This patch fixes the bug, assiging Assigning. > "-EBUSY" to err on the path that request_region() fails. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188931 > > Signed-off-by: Pan Bian > --- And here you're supposed to describe changes in the different patch versions... [...] MBR, Sergei