Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751266AbcLDT5Q (ORCPT ); Sun, 4 Dec 2016 14:57:16 -0500 Received: from mail-pg0-f42.google.com ([74.125.83.42]:34085 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750979AbcLDT5P (ORCPT ); Sun, 4 Dec 2016 14:57:15 -0500 Date: Sun, 4 Dec 2016 11:57:07 -0800 From: Omar Sandoval To: Pan Bian Cc: Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] btrfs: fix improper return value Message-ID: <20161204195707.GA21783@vader> References: <1480827113-3928-1-git-send-email-bianpan2016@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1480827113-3928-1-git-send-email-bianpan2016@163.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 966 Lines: 34 On Sun, Dec 04, 2016 at 12:51:53PM +0800, Pan Bian wrote: > In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret > on errors. However, it directly returns 0. It may be better to return > ret. This patch also removes the warning, because the caller already > prints a warning. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731 Looks good. Reviewed-by: Omar Sandoval > Signed-off-by: Pan Bian > --- > fs/btrfs/uuid-tree.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/btrfs/uuid-tree.c b/fs/btrfs/uuid-tree.c > index 7fc89e4..83bb2f2 100644 > --- a/fs/btrfs/uuid-tree.c > +++ b/fs/btrfs/uuid-tree.c > @@ -351,7 +351,5 @@ int btrfs_uuid_tree_iterate(struct btrfs_fs_info *fs_info, > > out: > btrfs_free_path(path); > - if (ret) > - btrfs_warn(fs_info, "btrfs_uuid_tree_iterate failed %d", ret); > - return 0; > + return ret; > } > -- > 1.9.1 > >