Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631AbcLEES5 (ORCPT ); Sun, 4 Dec 2016 23:18:57 -0500 Received: from smtp-fw-9101.amazon.com ([207.171.184.25]:48014 "EHLO smtp-fw-9101.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbcLEESx (ORCPT ); Sun, 4 Dec 2016 23:18:53 -0500 X-IronPort-AV: E=Sophos;i="5.33,302,1477958400"; d="scan'208";a="663427595" Date: Sun, 4 Dec 2016 20:18:15 -0800 From: Matt Wilson To: Netanel Belgazal CC: , , , , , , , , , Subject: Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration Message-ID: <20161205041815.GE4310@u54ee753d2d1854bda401.ant.amazon.com> References: <1480857578-5065-1-git-send-email-netanel@annapurnalabs.com> <1480857578-5065-5-git-send-email-netanel@annapurnalabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1480857578-5065-5-git-send-email-netanel@annapurnalabs.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1612 Lines: 51 On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: > ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type > treat the ena_flow_hash_to_flow_type enum as power of two values. > > Change the values of ena_admin_flow_hash_fields to be power of two values. Then I generally prefer BIT(0), BIT(1), BIT(2), etc. Also it would be helpful to include some comments about the consequences of the current state of the code. --msw > Signed-off-by: Netanel Belgazal > --- > drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/ethernet/amazon/ena/ena_admin_defs.h b/drivers/net/ethernet/amazon/ena/ena_admin_defs.h > index a46e749..f48c886 100644 > --- a/drivers/net/ethernet/amazon/ena/ena_admin_defs.h > +++ b/drivers/net/ethernet/amazon/ena/ena_admin_defs.h > @@ -631,22 +631,22 @@ enum ena_admin_flow_hash_proto { > /* RSS flow hash fields */ > enum ena_admin_flow_hash_fields { > /* Ethernet Dest Addr */ > - ENA_ADMIN_RSS_L2_DA = 0, > + ENA_ADMIN_RSS_L2_DA = 0x1, > > /* Ethernet Src Addr */ > - ENA_ADMIN_RSS_L2_SA = 1, > + ENA_ADMIN_RSS_L2_SA = 0x2, > > /* ipv4/6 Dest Addr */ > - ENA_ADMIN_RSS_L3_DA = 2, > + ENA_ADMIN_RSS_L3_DA = 0x4, > > /* ipv4/6 Src Addr */ > - ENA_ADMIN_RSS_L3_SA = 5, > + ENA_ADMIN_RSS_L3_SA = 0x8, > > /* tcp/udp Dest Port */ > - ENA_ADMIN_RSS_L4_DP = 6, > + ENA_ADMIN_RSS_L4_DP = 0x10, > > /* tcp/udp Src Port */ > - ENA_ADMIN_RSS_L4_SP = 7, > + ENA_ADMIN_RSS_L4_SP = 0x20, > }; > > struct ena_admin_proto_input {