Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751437AbcLEEkq (ORCPT ); Sun, 4 Dec 2016 23:40:46 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33544 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751120AbcLEEkn (ORCPT ); Sun, 4 Dec 2016 23:40:43 -0500 Subject: Re: [PATCH v6 1/2] mtd: arasan: Add device tree binding documentation To: Punnaiah Choudary Kalluri , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, richard@nod.at, cyrille.pitchen@atmel.com, robh+dt@kernel.org, mark.rutland@arm.com References: <1480911066-26157-1-git-send-email-punnaia@xilinx.com> Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, michals@xilinx.com, kalluripunnaiahchoudary@gmail.com, kpc528@gmail.com, Punnaiah Choudary Kalluri From: Marek Vasut Message-ID: <74842d92-840d-a7c2-fb1b-ddab1ac2cf42@gmail.com> Date: Mon, 5 Dec 2016 05:25:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480911066-26157-1-git-send-email-punnaia@xilinx.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2465 Lines: 89 On 12/05/2016 05:11 AM, Punnaiah Choudary Kalluri wrote: > This patch adds the dts binding document for arasan nand flash > controller. > > Signed-off-by: Punnaiah Choudary Kalluri > Acked-by: Rob Herring > --- > changes in v6: > - Removed num-cs property > - Separated nandchip from nand controller > changes in v5: > - None > Changes in v4: > - Added num-cs property > - Added clock support > Changes in v3: > - None > Changes in v2: > - None > --- > .../devicetree/bindings/mtd/arasan_nfc.txt | 38 ++++++++++++++++++++++ > 1 file changed, 38 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/arasan_nfc.txt > > diff --git a/Documentation/devicetree/bindings/mtd/arasan_nfc.txt b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > new file mode 100644 > index 0000000..dcbe7ad > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/arasan_nfc.txt > @@ -0,0 +1,38 @@ > +Arasan Nand Flash Controller with ONFI 3.1 support Arasan NAND Flash ... > +Required properties: > +- compatible: Should be "arasan,nfc-v3p10" This v3p10 looks like version 3 patchlevel 10, but shouldn't we have some fallback option which doesn't encode IP version in the compat string ? Also, shouldn't quirks be handled by DT props instead of effectively encoding them into the compatible string ? > +- reg: Memory map for module access > +- interrupt-parent: Interrupt controller the interrupt is routed through > +- interrupts: Should contain the interrupt for the device > +- clock-name: List of input clocks - "clk_sys", "clk_flash" > + (See clock bindings for details) > +- clocks: Clock phandles (see clock bindings for details) > + > +Optional properties: > +- arasan,has-mdma: Enables Dma support 'Enables DMA support' , with DMA in caps. > +for nand partition information please refer the below file For NAND ... > +Documentation/devicetree/bindings/mtd/partition.txt > + > +Example: > + nand0: nand@ff100000 { > + compatible = "arasan,nfc-v3p10" > + reg = <0x0 0xff100000 0x1000>; > + clock-name = "clk_sys", "clk_flash" > + clocks = <&misc_clk &misc_clk>; > + interrupt-parent = <&gic>; > + interrupts = <0 14 4>; > + arasan,has-mdma; > + #address-cells = <1>; > + #size-cells = <0> > + > + nand@0 { > + reg = <0> > + partition@0 { > + label = "filesystem"; > + reg = <0x0 0x0 0x1000000>; > + }; > + (...) > + }; > + }; > -- Best regards, Marek Vasut