Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752643AbcLEJTA (ORCPT ); Mon, 5 Dec 2016 04:19:00 -0500 Received: from mail-io0-f196.google.com ([209.85.223.196]:34838 "EHLO mail-io0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752656AbcLEJR1 (ORCPT ); Mon, 5 Dec 2016 04:17:27 -0500 MIME-Version: 1.0 In-Reply-To: <1480925763-20254-1-git-send-email-nikita.yoush@cogentembedded.com> References: <1480925763-20254-1-git-send-email-nikita.yoush@cogentembedded.com> From: Geert Uytterhoeven Date: Mon, 5 Dec 2016 10:16:44 +0100 X-Google-Sender-Auth: IBi48cT1vatl0GTve2Mxqs6Mo6s Message-ID: Subject: Re: [patch net v2] net: fec: fix compile with CONFIG_M5272 To: Nikita Yushchenko Cc: "David S. Miller" , Fugang Duan , Troy Kisky , Andrew Lunn , Eric Nelson , Philippe Reynes , Johannes Berg , "netdev@vger.kernel.org" , Chris Healy , Fabio Estevam , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 973 Lines: 25 On Mon, Dec 5, 2016 at 9:16 AM, Nikita Yushchenko wrote: > Commit 4dfb80d18d05 ("net: fec: cache statistics while device is down") > introduced unconditional statistics-related actions. > > However, when driver is compiled with CONFIG_M5272, staticsics-related > definitions do not exist, which results into build errors. > > Fix that by adding explicit handling of !defined(CONFIG_M5272) case. > > Fixes: 4dfb80d18d05 ("net: fec: cache statistics while device is down") > Signed-off-by: Nikita Yushchenko Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds