Date: Mon, 5 Dec 2016 14:47:43 +0100
From: Pavel Machek <pavel@ucw.cz>
To: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vt: fix Scroll Lock LED trigger name
Message-ID: <20161205134743.GB30774@amd>
References: <e8a3a0ac-1f41-be9a-a943-59a085d01c71@maciej.szmigiero.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="gj572EiMnwbLXET9"
Content-Disposition: inline
In-Reply-To: <e8a3a0ac-1f41-be9a-a943-59a085d01c71@maciej.szmigiero.name>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2026
Lines: 59


--gj572EiMnwbLXET9
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> There is a disagreement between drivers/tty/vt/keyboard.c and
> drivers/input/input-leds.c with regard to what is a Scroll Lock LED
> trigger name: input calls it "kbd-scrolllock", but vt calls it
> "kbd-scrollock" (two l's).
> This prevents Scroll Lock LED trigger from binding to this LED by default.
>=20
> Since it is a scroLL Lock LED, this interface was introduced only about a
> year ago and in an Internet search people seem to reference this trigger
> only to set it to this LED let's simply rename it to "kbd-scrolllock".
>=20
> Also, it looks like this was supposed to be changed before this code was
> merged: https://lkml.org/lkml/2015/6/9/697 but it was done only on
> the input side.
>=20
> Signed-off-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
> ---
>  drivers/tty/vt/keyboard.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
> index d5d81d4d3c04..3dd6a491cdba 100644
> --- a/drivers/tty/vt/keyboard.c
> +++ b/drivers/tty/vt/keyboard.c
> @@ -982,7 +982,7 @@ static void kbd_led_trigger_activate(struct led_class=
dev *cdev)
>  	KBD_LED_TRIGGER((_led_bit) + 8, _name)
> =20
>  static struct kbd_led_trigger kbd_led_triggers[] =3D {
> -	KBD_LED_TRIGGER(VC_SCROLLOCK, "kbd-scrollock"),
> +	KBD_LED_TRIGGER(VC_SCROLLOCK, "kbd-scrolllock"),

Would it be feasible to rename "VC_SCROLLOCK" to "VC_SCROLLLOCK", too?

--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--gj572EiMnwbLXET9
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlhFb/8ACgkQMOfwapXb+vJl7ACgoXAsHM6ksQjpgOGUTDQf8ms6
x9kAnR30Vsc2jlHigycufIKHALU6P//E
=AyNy
-----END PGP SIGNATURE-----

--gj572EiMnwbLXET9--