Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752109AbcLEPmy convert rfc822-to-8bit (ORCPT ); Mon, 5 Dec 2016 10:42:54 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:4785 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbcLEPmw (ORCPT ); Mon, 5 Dec 2016 10:42:52 -0500 From: Salil Mehta To: David Miller CC: "Zhuangyuzeng (Yisen)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack Thread-Topic: [PATCH V2 net-next] net: hns: Fix to conditionally convey RX checksum flag to stack Thread-Index: AQHSSkHpMFDOpU42u0SRd9dvOPMXEKDx6oyAgADkfKCAAILh8IADYEmAgALVCRA= Date: Mon, 5 Dec 2016 15:42:35 +0000 Message-ID: References: <20161129130945.919372-1-salil.mehta@huawei.com> <20161130.142539.1927956259851457047.davem@davemloft.net> <20161203.152515.1155017126921048869.davem@davemloft.net> In-Reply-To: <20161203.152515.1155017126921048869.davem@davemloft.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.153] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.58458AF6.03F4,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: c086d779e9ef8a8e6af9457a7c39ac4d Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 835 Lines: 26 > -----Original Message----- > From: David Miller [mailto:davem@davemloft.net] > Sent: Saturday, December 03, 2016 8:25 PM > To: Salil Mehta > Cc: Zhuangyuzeng (Yisen); mehta.salil.lnk@gmail.com; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Linuxarm > Subject: Re: [PATCH V2 net-next] net: hns: Fix to conditionally convey > RX checksum flag to stack > > From: Salil Mehta > Date: Thu, 1 Dec 2016 16:59:14 +0000 > > > It looks to me the cumbersome check in the PATCH V2 should > > be retained. > > I really want something simpler with small checks that are > done in logical pieces in a straigtforward progression. > > The code in V2 is completely unreadable. Hi David, I understand your concern. I have floated the Patch V3 with re-structured code for your review. Thanks! Best regards Salil