Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbcLEPtW (ORCPT ); Mon, 5 Dec 2016 10:49:22 -0500 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:44834 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751378AbcLEPtU (ORCPT ); Mon, 5 Dec 2016 10:49:20 -0500 Subject: Re: [PATCH] Fixed to checkpatch.pl errors to vlan_dev.c To: Ozgur Karatas , kaber@trash.net, David Miller References: <52561480952041@web13j.yandex.ru> Cc: netdev , linux-kernel From: Stefan Schmidt Message-ID: <98f13d7e-69e5-a392-bd95-d615dbfcba3f@osg.samsung.com> Date: Mon, 5 Dec 2016 16:48:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <52561480952041@web13j.yandex.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1014 Lines: 35 Hello. On 05/12/16 16:34, Ozgur Karatas wrote: > Hello all, > > I will solve a checkpatch errors. > > Signed-off-by: Ozgur Karatas The patch itself looks good, but please have a read about having a good commit message. I would suggest reading Documentation/SubmittingPatches section 14: The canonical patch format Especially the parts about the subject line and summary. > > --- > net/8021q/vlan_dev.c | 2 +- > diff --git a/net/8021q/vlan_dev.c b/net/8021q/vlan_dev.c > index fbfacd5..2edb495 100644 > --- a/net/8021q/vlan_dev.c > +++ b/net/8021q/vlan_dev.c > @@ -738,7 +738,7 @@ static int vlan_dev_netpoll_setup(struct net_device *dev, struct netpoll_info *n > > static void vlan_dev_netpoll_cleanup(struct net_device *dev) > { > - struct vlan_dev_priv *vlan= vlan_dev_priv(dev); > + struct vlan_dev_priv *vlan = vlan_dev_priv(dev); > struct netpoll *netpoll = vlan->netpoll; > > if (!netpoll) > regards Stefan Schmidt