Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752648AbcLEQcs (ORCPT ); Mon, 5 Dec 2016 11:32:48 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:53800 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751396AbcLEQcq (ORCPT ); Mon, 5 Dec 2016 11:32:46 -0500 Date: Mon, 5 Dec 2016 09:32:35 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: Peter Huewe , Marcel Selhorst , "moderated list:TPM DEVICE DRIVER" , open list Subject: Re: [PATCH v2 3/3] tpm_crb: request and relinquish locality 0 Message-ID: <20161205163235.GA24852@obsidianresearch.com> References: <20161203175213.10210-1-jarkko.sakkinen@linux.intel.com> <20161203175213.10210-4-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161203175213.10210-4-jarkko.sakkinen@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 196 Lines: 6 On Sat, Dec 03, 2016 at 07:52:13PM +0200, Jarkko Sakkinen wrote: > + iowrite32(CRB_LOC_CTRL_RELINQUISH, &priv->regs_h->loc_ctrl); Since regs_h can be null shouldn't there be some guards ? Jason