Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbcLER13 (ORCPT ); Mon, 5 Dec 2016 12:27:29 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:17072 "EHLO imgpgp01.kl.imgtec.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751993AbcLER10 (ORCPT ); Mon, 5 Dec 2016 12:27:26 -0500 X-PGP-Universal: processed; by imgpgp01.kl.imgtec.org on Mon, 05 Dec 2016 18:28:02 +0000 From: Paul Burton To: "Maciej W. Rozycki" CC: Matt Redfearn , Ralf Baechle , , "Jason A . Donenfeld" , Thomas Gleixner , , James Hogan Subject: Re: [PATCH 3/5] MIPS: Only change $28 to thread_info if coming from user mode Date: Mon, 5 Dec 2016 17:27:11 +0000 Message-ID: <40031221.jIbnRxB01Q@np-p-burton> Organization: Imagination Technologies User-Agent: KMail/5.3.3 (Linux/4.8.10-1-ARCH; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <1480685957-18809-1-git-send-email-matt.redfearn@imgtec.com> <1480685957-18809-4-git-send-email-matt.redfearn@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1953937.a2uVhPrRmM"; micalg=pgp-sha256; protocol="application/pgp-signature" X-Originating-IP: [10.100.200.179] X-ESG-ENCRYPT-TAG: 1b7d744b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2093 Lines: 46 --nextPart1953937.a2uVhPrRmM Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hi Maciej, > Overall I think all code should be using the (default) > `.set reorder' mode, perhaps forced explicitly in case these macros are > pasted into `.set noreorder' code, to make it easier to avoid subtle data > dependency bugs, and also to make R6 porting easier. Except maybe for the > RFE sequence, for readability's sake, although even there GAS will do the > right thing. Surely the BLTZ/MOVE piece does not have to be `.set > noreorder' as GAS will schedule that delay slot automatically if allowed > to. Agreed we ought to use .set reorder (or rather, not use .set noreorder) wherever possible but FYI one thing I've only noticed recently is that we don't actually get any reordering anyway, presumably because we don't provide any -O flags when building asm source. I haven't yet done the legwork or figuring out whether we've ever had optimisation & if so what changed... Thanks, Paul --nextPart1953937.a2uVhPrRmM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEELIGR03D5+Fg+69wPgiDZ+mk8HGUFAlhFo28ACgkQgiDZ+mk8 HGVCEQ/9GrNOneHNyUO4Z8eogunJmAe6kpSvpHClNaSkC/UJwhDm/b6q+PPYiH1n KFqAEiWGdEhguWH64LiY0NZwyzyg/6yinfnDBGjq0Tslmw7azNdKDPzOJ+z00Bx8 bwdZRZFZK+ALngY25bTDC6mmM2lHmiQsSK2xS3iQbas4iCIz9yQ/w84Fv3QDjVZa 26bjGTy+stEJz2eJ2L60a44qfAB3NLc/O8oapxEIS5/d4FiLkLXCTBa3GDQJMun8 L92SiuWJVxRYnsjDlAWW1/8ChseFJW51f/VomVYS6gwteOLWiYK3Csk4snBhPEp1 A1UHmMsC6/YeV/u6Esjl7VWdN767FwvPBsrZlqm10U0HkVG6TkU2fdVyQ9IiSmFq iWaCe8zPOoJvJTUEM8fZLSReK1raAQfijufiaVPrVbPRcZab9Nqm2MHf4gcxvShy 57R5D17E/rAyW67um6thsJuGVPGa2tFuyN8oyyyRSaqvSWm/aW4ehEaAkY21gnLg 1I4dqEeGE2gxv4lvqxqMoQRdNtebn75OaBqPFdOVIirq1rkW51C+yf/XHlcL4zce v5r5U4Pfkknx5k+DUpz7HoX9eOmVe/tHCuEa4qH0QKCaBVwwLU2DOJCa+r8kx+lf mDu6PnZJPs1Z6tvDelS3qUUCkQs56qB0V09rarrCr7KQDWrdIxo= =Pblh -----END PGP SIGNATURE----- --nextPart1953937.a2uVhPrRmM--