Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752087AbcLESEq (ORCPT ); Mon, 5 Dec 2016 13:04:46 -0500 Received: from us-mx1.synaptics.com ([192.147.44.131]:14748 "EHLO us-mx1.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751443AbcLESEo (ORCPT ); Mon, 5 Dec 2016 13:04:44 -0500 Subject: Re: [PATCH] Input: synaptics-rmi4 - fix debug for sensor clip To: Nick Dyer , Dmitry Torokhov References: <1480899881-31425-1-git-send-email-nick@shmanahar.org> CC: Chris Healy , Benjamin Tissoires , , From: Andrew Duggan Message-ID: Date: Mon, 5 Dec 2016 10:04:43 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1480899881-31425-1-git-send-email-nick@shmanahar.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.4.10.103] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1307 Lines: 38 On 12/04/2016 05:04 PM, Nick Dyer wrote: > The debug would only ever output zero for the clip information. > > Signed-off-by: Nick Dyer Reviewed-by: Andrew Duggan > --- > > drivers/input/rmi4/rmi_f12.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_f12.c b/drivers/input/rmi4/rmi_f12.c > index 8c5360c..e35c64b 100644 > --- a/drivers/input/rmi4/rmi_f12.c > +++ b/drivers/input/rmi4/rmi_f12.c > @@ -71,10 +71,6 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12) > u8 buf[15]; > int pitch_x = 0; > int pitch_y = 0; > - int clip_x_low = 0; > - int clip_x_high = 0; > - int clip_y_low = 0; > - int clip_y_high = 0; > int rx_receivers = 0; > int tx_receivers = 0; > int sensor_flags = 0; > @@ -127,7 +123,8 @@ static int rmi_f12_read_sensor_tuning(struct f12_data *f12) > } > > rmi_dbg(RMI_DEBUG_FN, &fn->dev, "%s: x low: %d x high: %d y low: %d y high: %d\n", > - __func__, clip_x_low, clip_x_high, clip_y_low, clip_y_high); > + __func__, sensor->axis_align.clip_x_low, sensor->axis_align.clip_x_high, > + sensor->axis_align.clip_y_low, sensor->axis_align.clip_y_high); > > if (rmi_register_desc_has_subpacket(item, 3)) { > rx_receivers = buf[offset];